Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump detect-indent to 7.0.1 #5666

Merged
merged 2 commits into from
Nov 23, 2022
Merged

Conversation

gwhitney
Copy link
Contributor

Note this had to be done by switching to the fork
@gwhitney/detect-indent, because
sindresorhus/detect-indent no longer provides
CommonJS exports.

Resolves #5664.

@gwhitney
Copy link
Contributor Author

gwhitney commented Nov 22, 2022

I am really sorry but I can't decipher what the failure on Windows is -- the most specific error information I can find in the "Details" above is at line 2289 of the "run tests (branch)" step, namely

FAIL test/exec.e2e.ts (106.884 s)
  ● pnpm recursive exec works with PnP
     "pnpm recursive exec" failed in 1 packages

but that doesn't localize it very well; which package did it fail in? (Maybe I was unable to find an earlier message?) Any guidance as to how to track this down -- especially without a Windows machine at my disposal :-( -- would be very welcome. Happy to fix whatever it is, but not really sure how to find the problem. (I mean, I imagine it's something to do with line separation characters or something like that? But that's very arcane to me, with zero Windows experience.)

@zkochan
Copy link
Member

zkochan commented Nov 23, 2022

Windows failure is unrelated to your change.

@zkochan zkochan merged commit fec9e31 into pnpm:main Nov 23, 2022
@zkochan zkochan added this to the v7.17 milestone Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

detect-intent is buggy and we cannot update it
2 participants