Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: restore extend-node-path option #5910

Merged
merged 4 commits into from Jan 13, 2023

Conversation

asprouse
Copy link
Contributor

Restore the extend-node-path option to fix/workaround #5176

@welcome
Copy link

welcome bot commented Jan 10, 2023

💖 Thanks for opening this pull request! 💖
Please be patient and we will get back to you as soon as we can.

@zkochan
Copy link
Member

zkochan commented Jan 11, 2023

I think it is OK to add this setting. But let's maybe add a test.

@asprouse asprouse force-pushed the restore-extend-node-path-option branch from 283d536 to db6aef0 Compare January 12, 2023 17:55
@asprouse asprouse force-pushed the restore-extend-node-path-option branch from db6aef0 to 268e4ce Compare January 12, 2023 20:15
@asprouse
Copy link
Contributor Author

I think it is OK to add this setting. But let's maybe add a test.

Ok I added a simple test to the get-context package. There wasn't any tests for this package so it really only tests the new feature in this PR. Happy to add more tests elsewhere if needed. Is there a more established test suite that I should add to?

@zkochan zkochan merged commit 28b47a1 into pnpm:main Jan 13, 2023
@welcome
Copy link

welcome bot commented Jan 13, 2023

Congrats on merging your first pull request! 🎉🎉🎉

@zkochan zkochan added this to the v7.25 milestone Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants