fix: don't include the version for local directory dependencies #6695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need to include the version of a dependency in the lockfile, if that dependency is installed from a local directory
zkochan
force-pushed
the
no-version-for-local-dep
branch
from
ff5893b
to
6a6a1bd
Compare
davidfirst
approved these changes
Jun 21, 2023
GiladShoham
approved these changes
Jun 21, 2023
|
Do things still work if a workspace has multiple versions of the same package in the same workspace and needs to resolve them separately, like on DT? My impression was that the lockfile contents are used for resolution and so the version may matter. |
|
It should work because the file location is used as the pkg id. The version is redundant information that isn't used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to include the version of a dependency in the lockfile,
if that dependency is installed from a local directory