perf: improve tarball fetching speed #6819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zkochan
force-pushed
the
fetch-perf
branch
2 times, most recently
from
27e1818
to
1575bd2
Compare
zkochan
added a commit
that referenced
this pull request
Aug 4, 2023
zkochan
added a commit
that referenced
this pull request
Aug 4, 2023
dmichon-msft
reviewed
Aug 8, 2023
| @@ -158,27 +160,57 @@ export function createDownloader ( | |||
| ? throttle(opts.onProgress, 500) | |||
| : undefined | |||
| let downloaded = 0 | |||
| const chunks: Buffer[] = [] | |||
| res.body!.on('data', (chunk: Buffer) => { | |||
There was a problem hiding this comment.
Since you aren't wrapping any callback-based APIs other than the data event here, you might find it convenient to take advantage of the fact that Node's Readable interface implements [Symbol.asyncIterator]:
// This will handle the 'data', 'error', and 'end' events.
for await (const chunk of res.body) {
chunks.push(chunk);
downloaded += chunk.length;
onProgress?.(downloaded);
}
if (size !== null && size !== downloaded) {
throw new BadTarballError(...);
}
// etc.
zkochan
commented
Aug 8, 2023
| @@ -130,7 +130,7 @@ test('fail when integrity check fails two times in a row', async () => { | |||
| new TarballIntegrityError({ | |||
| algorithm: 'sha512', | |||
| expected: 'sha1-HssnaJydJVE+rbyZFKc/VAi+enY=', | |||
| found: 'sha512-VuFL1iPaIxJK/k3gTxStIkc6+wSiDwlLdnCWNZyapsVLobu/0onvGOZolASZpfBFiDJYrOIGiDzgLIULTW61Vg== sha1-ACjKMFA7S6uRFXSDFfH4aT+4B4Y=', | |||
| found: 'sha1-ACjKMFA7S6uRFXSDFfH4aT+4B4Y=', | |||
There was a problem hiding this comment.
I am not sure why this test had to be changed but I guess it is OK. The error message is even better this way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related comment: https://github.com/orgs/pnpm/discussions/6376#discussioncomment-6420573