Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(interactive-update): group dependancies by type, add package url column #6978

Merged
merged 3 commits into from
Aug 30, 2023
Merged

feat(interactive-update): group dependancies by type, add package url column #6978

merged 3 commits into from
Aug 30, 2023

Conversation

th3fallen
Copy link
Contributor

Partially resolves #6314

Notes:

  • I really hate how the table rows are generated as it makes it nearly impossible to segment by dependency type while preserving column widths.

@welcome
Copy link

welcome bot commented Aug 22, 2023

💖 Thanks for opening this pull request! 💖
Please be patient and we will get back to you as soon as we can.

@th3fallen th3fallen force-pushed the add-repository-url-to-interactive-update branch 2 times, most recently from c126a4b to 58961a3 Compare August 23, 2023 13:20
@th3fallen
Copy link
Contributor Author

Have i mentioned my hatred for the whitespace strictness in those tests 😆 fix pushed

@zkochan
Copy link
Member

zkochan commented Aug 24, 2023

When I run this on the pnpm repo, I see many duplications of the same package and also some empty lines

image

@th3fallen
Copy link
Contributor Author

th3fallen commented Aug 24, 2023 •
edited

you ran it in the root of the repo? ah nm, i see you ran with the -r flag... interesting.... will investigate

@th3fallen th3fallen force-pushed the add-repository-url-to-interactive-update branch from 58961a3 to f233c85 Compare August 25, 2023 16:51
@th3fallen
Copy link
Contributor Author

Pushed an update that now properly dedupes but allows duplicates if the version are not the same (from prior behavior) also added a "workspace" column if workspaces are enabled to give an idea of where each package is coming from.

@th3fallen th3fallen force-pushed the add-repository-url-to-interactive-update branch 3 times, most recently from 9ccd9dc to 42dfbd9 Compare August 28, 2023 15:19
@th3fallen th3fallen force-pushed the add-repository-url-to-interactive-update branch from 42dfbd9 to 7c57c89 Compare August 29, 2023 00:55
@th3fallen
Copy link
Contributor Author

well at least those failures weren't from me this time i guess 😆

@zkochan
Copy link
Member

zkochan commented Aug 30, 2023

ok, I'll review later.

@zkochan zkochan mentioned this pull request Aug 30, 2023
Closed
@zkochan zkochan merged commit 81e5ada into pnpm:main Aug 30, 2023
7 checks passed
@welcome
Copy link

welcome bot commented Aug 30, 2023

Congrats on merging your first pull request! 🎉🎉🎉

@th3fallen th3fallen deleted the add-repository-url-to-interactive-update branch August 30, 2023 19:27
@zkochan zkochan mentioned this pull request Aug 31, 2023
Closed
1 task
@gluxon gluxon mentioned this pull request Sep 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zkochan zkochan Awaiting requested review from zkochan zkochan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

interactive update: show link to changelog
2 participants
@th3fallen @zkochan