Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't copy optional dependencies from the store #7255

Merged
merged 6 commits into from
Oct 31, 2023
Merged

fix: don't copy optional dependencies from the store #7255

merged 6 commits into from
Oct 31, 2023

Conversation

zkochan
Copy link
Member

@zkochan zkochan commented Oct 30, 2023

close #7046

@zkochan zkochan mentioned this pull request Oct 30, 2023
Merged
@tris203
Copy link
Contributor

tris203 commented Oct 30, 2023 •
edited

Looks good to me, although I still don't like the idea of the lockfile being "wrong" and fixing it at install time. I think it's cleaner to have it set correctly in the lockfile if possible

@zkochan zkochan marked this pull request as ready for review October 31, 2023 01:50
@zkochan zkochan requested review from a team and tris203 October 31, 2023 01:51
gluxon
gluxon approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@gluxon gluxon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

.changeset/mean-panthers-teach.md Outdated Show resolved Hide resolved
tris203
tris203 approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@tris203 tris203 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

.changeset/mean-panthers-teach.md Outdated Show resolved Hide resolved
pkg-manager/core/test/install/optionalDependencies.ts Outdated Show resolved Hide resolved
@zkochan zkochan merged commit cfc017e into main Oct 31, 2023
17 checks passed
@zkochan zkochan deleted the fix/7046 branch October 31, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gluxon gluxon gluxon approved these changes

@tris203 tris203 tris203 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Certain files aren't hardlinked on Windows, and are duplicated instead.
3 participants
@zkochan @tris203 @gluxon