Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolve peer having peer correctly #7583

Merged
merged 6 commits into from
Jan 30, 2024
Merged

fix: resolve peer having peer correctly #7583

merged 6 commits into from
Jan 30, 2024

Conversation

zkochan
Copy link
Member

@zkochan zkochan commented Jan 28, 2024

close #7444

@zkochan zkochan marked this pull request as ready for review January 30, 2024 16:56
weyert
weyert approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@weyert weyert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I tried it out on my mono repo at work and I didn't notice any problems

@zkochan zkochan merged commit 977060f into main Jan 30, 2024
13 of 14 checks passed
@zkochan zkochan deleted the fix/7444 branch January 30, 2024 23:28
zkochan added a commit that referenced this pull request Jan 30, 2024
@zkochan
fix: resolve peer having peer correctly (#7583)
44062ee 
close #7444
@zkochan zkochan mentioned this pull request Jan 31, 2024
Merged
zkochan added a commit to teambit/bit that referenced this pull request Jan 31, 2024
@zkochan
fix: update pnpm (#8481)
96522bf 
## Proposed Changes

- pnpm/pnpm#7583
- pnpm/pnpm#7563
- pnpm/pnpm#7591
@zkochan zkochan mentioned this pull request Feb 2, 2024
Closed
4 tasks
zkochan added a commit that referenced this pull request Feb 3, 2024
@zkochan
revert: resolve peer having peer correctly
f5eadba 
ref #7583
zkochan added a commit that referenced this pull request Feb 3, 2024
@zkochan
revert: resolve peer having peer correctly
7b0d5c2 
ref #7583
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weyert weyert weyert approved these changes

@gluxon gluxon Awaiting requested review from gluxon gluxon is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent lockfile changes on repeat installs
2 participants
@zkochan @weyert