Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: link overrides should be able to use absolute path #7749

Merged
merged 4 commits into from Mar 10, 2024

Conversation

yjrhgvbn
Copy link
Contributor

@yjrhgvbn yjrhgvbn commented Mar 8, 2024

pnpm will install a wrong dependency when link override is an absolute path

"pnpm": {
    "overrides": {
      "test": "link:/absolute-path//test"
    }
  }

@yjrhgvbn yjrhgvbn requested a review from zkochan as a code owner March 8, 2024 17:29
Copy link

welcome bot commented Mar 8, 2024

💖 Thanks for opening this pull request! 💖
Please be patient and we will get back to you as soon as we can.

@zkochan
Copy link
Member

zkochan commented Mar 9, 2024

Add a changeset as described in CONTRIBUTING.md

@yjrhgvbn
Copy link
Contributor Author

yjrhgvbn commented Mar 9, 2024

add it

@zkochan zkochan merged commit 0963390 into pnpm:main Mar 10, 2024
7 checks passed
Copy link

welcome bot commented Mar 10, 2024

Congrats on merging your first pull request! 🎉🎉🎉

@gluxon
Copy link
Member

gluxon commented Mar 11, 2024

Thanks for adding this @yjrhgvbn!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants