Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dlx): dlx should not read settings from the cwd #7916

Merged
merged 4 commits into from Apr 13, 2024
Merged

Conversation

zkochan
Copy link
Member

@zkochan zkochan commented Apr 13, 2024

No description provided.

@zkochan zkochan marked this pull request as ready for review April 13, 2024 12:31
@zkochan zkochan merged commit 0995ae3 into main Apr 13, 2024
12 of 13 checks passed
@zkochan zkochan deleted the fix-dlx-dir branch April 13, 2024 13:10
zkochan added a commit that referenced this pull request Apr 13, 2024
@eifr
Copy link

eifr commented Apr 17, 2024

I just updated to 9.0.1 and this feat doesn't seem to work when running dlx inside a npm script.
I use pnpm serve and it should run pnpm dlx concurrently..., but it fails to download concurrently, im getting 401.

I use npmrc with my own artifact server and it works with pnpm i btw

@eifr
Copy link

eifr commented Apr 17, 2024

@zkochan ^^

@zkochan
Copy link
Member Author

zkochan commented Apr 17, 2024

Why do you use pnpm dlx in scripts at all? concurrently should be added to the dev dependencies.

configure the artifact server in the global .npmrc and it should work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants