-
Notifications
You must be signed in to change notification settings - Fork 5
Conversation
faea657
to
656f1a2
Compare
4323097
to
21b559e
Compare
Don't search for bins if they are not specified in `package.json`. Also, link bins only once the package's content is linked to the project's `node_modules`.
42a04ce
to
577a4f4
Compare
577a4f4
to
cf4322b
Compare
Pure packages are packages that don't rely on external peer deps. External peer deps are peer deps resolved from upper in the dep tree. BREAKING CHANGE: Peer dependencies are always grouped with the relying packages. Even when the peer dependencies are top dependencies.
All tests pass but |
depth: options.currentDepth, | ||
installable, | ||
|
||
ctx.installs[fetchedPkg.id] = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be set before running installDependencies()
As of now, with these changes, pnpm has the same speed as without them. |
Cool. Is it ready to test? Can you publish a beta and I will test on my
massive monolith.
…On Fri 25. Aug 2017 at 11:11 PM, Zoltan Kochan ***@***.***> wrote:
As of now, with these changes, pnpm has the same speed as without them.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#8 (comment)>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/AARLRaNO5Ra6N468o6wytFadSolKQxWYks5sbziVgaJpZM4OwxzN>
.
|
I want to try to make it a little bit faster than the current version (to justify the huge changes). I will probably do this: pnpm/pnpm#841. It will allow saving the shrinkwrap and store index files earlier. Also, André Staltz suggested using most instead of rxjs. He says sometimes it is a lot faster than rxjs. I might try that... or maybe later as it might be a lot of work. I'll publish a beta this weekend though. |
2aacd83
to
cfdc234
Compare
7ef0594
to
f6783c4
Compare
@vjpr I published the changes as |
I reverted the breaking changes. They were not necessary, so this will be a minor version bump in pnpm |
Breaking changes:
Peer dependencies are always grouped with the relying packages.Even when the peer dependencies are top dependencies. 1fb94de
(the node_modules layout version might have to be bumped to
v2
)Fails on named install when node_modules is not up-to-date (Fail on named installs/uninstalls when node_modules is not up to date pnpm#841)