-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added optional threading support via python multiprocessing. #16
Conversation
ce021b1
to
a524ab4
Compare
- '2.7' | ||
- '3.2' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we removing support for python 3?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we are not - see tox.ini, environments are all there instead
so now testing is not different locally and on travis, just by running tox command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. In that case, should we remove the version from this yaml altogether and let travis use the default one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the point is to mention it explicitly for the debugging/reproducability
purpose, just to be sure what travis should use
On 16 March 2015 at 17:10, Patrick notifications@github.com wrote:
In .travis.yml
#16 (comment)
:
- '2.7'
-- '3.2'Got it. In that case, should we remove the version from this yaml
altogether and let travis use the default one?—
Reply to this email directly or view it on GitHub
https://github.com/pnpnpn/timeout-decorator/pull/16/files#r26499600.
Anatoly Bubenkov
… to pytest test runner
a524ab4
to
b1edeea
Compare
|
||
Derived from | ||
http://www.saltycrane.com/blog/2010/04/using-python-timeout-decorator-uploading-s3/ | ||
and https://code.google.com/p/verse-quiz/source/browse/trunk/timeout.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this? I am getting a 403 forbidden for this url.
Otherwise, 👍. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm it's something on the dying Google code. I'll check.
On Mar 16, 2015 7:15 PM, "Patrick" notifications@github.com wrote:
In README.rst
#16 (comment)
:
print "%d seconds have passed" % i
- if name == 'main':
mytest()
+.. warning::
- Make sure that in case of multiprocessing strategy for timeout, your function does not return objects which cannot
- be pickled, otherwise it will fail at marshalling it between master and child processes.
+Acknowledgement
+---------------
+
+Derived from
+http://www.saltycrane.com/blog/2010/04/using-python-timeout-decorator-uploading-s3/
+and https://code.google.com/p/verse-quiz/source/browse/trunk/timeout.pyWhat is this? I am getting a 403 forbidden for this url.
—
Reply to this email directly or view it on GitHub
https://github.com/pnpnpn/timeout-decorator/pull/16/files#r26512185.
@pnpnpn so i fixed all issues, looks like? |
I am still getting 403 on that url, but it's minor issue. I will merge. |
Added optional threading support via python multiprocessing.
looks like project was moved just few days ago, no idea where! |
thanks a lot for all the help! |
Added optional threading support via python multiprocessing.
Switched to pytest test runner.
Docs improvements.
closes #15