Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added optional threading support via python multiprocessing. #16

Merged
merged 1 commit into from
Mar 17, 2015

Conversation

bubenkoff
Copy link
Contributor

Added optional threading support via python multiprocessing.

Switched to pytest test runner.

Docs improvements.
closes #15

@bubenkoff bubenkoff force-pushed the multithreading-support branch 2 times, most recently from ce021b1 to a524ab4 Compare March 15, 2015 13:08
- '2.7'
- '3.2'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we removing support for python 3?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are not - see tox.ini, environments are all there instead
so now testing is not different locally and on travis, just by running tox command

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. In that case, should we remove the version from this yaml altogether and let travis use the default one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the point is to mention it explicitly for the debugging/reproducability
purpose, just to be sure what travis should use

On 16 March 2015 at 17:10, Patrick notifications@github.com wrote:

In .travis.yml
#16 (comment)
:

  • '2.7'
    -- '3.2'

Got it. In that case, should we remove the version from this yaml
altogether and let travis use the default one?


Reply to this email directly or view it on GitHub
https://github.com/pnpnpn/timeout-decorator/pull/16/files#r26499600.

Anatoly Bubenkov


Derived from
http://www.saltycrane.com/blog/2010/04/using-python-timeout-decorator-uploading-s3/
and https://code.google.com/p/verse-quiz/source/browse/trunk/timeout.py
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this? I am getting a 403 forbidden for this url.

Otherwise, 👍. Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm it's something on the dying Google code. I'll check.
On Mar 16, 2015 7:15 PM, "Patrick" notifications@github.com wrote:

In README.rst
#16 (comment)
:

  •        print "%d seconds have passed" % i
    
  • if name == 'main':
  •    mytest()
    
    +.. warning::
  • Make sure that in case of multiprocessing strategy for timeout, your function does not return objects which cannot
  • be pickled, otherwise it will fail at marshalling it between master and child processes.

+Acknowledgement
+---------------
+
+Derived from
+http://www.saltycrane.com/blog/2010/04/using-python-timeout-decorator-uploading-s3/
+and https://code.google.com/p/verse-quiz/source/browse/trunk/timeout.py

What is this? I am getting a 403 forbidden for this url.


Reply to this email directly or view it on GitHub
https://github.com/pnpnpn/timeout-decorator/pull/16/files#r26512185.

@bubenkoff
Copy link
Contributor Author

@pnpnpn so i fixed all issues, looks like?

@pnpnpn
Copy link
Owner

pnpnpn commented Mar 17, 2015

I am still getting 403 on that url, but it's minor issue. I will merge.

pnpnpn added a commit that referenced this pull request Mar 17, 2015
Added optional threading support via python multiprocessing.
@pnpnpn pnpnpn merged commit 3d66d09 into pnpnpn:master Mar 17, 2015
@bubenkoff
Copy link
Contributor Author

looks like project was moved just few days ago, no idea where!

@bubenkoff
Copy link
Contributor Author

thanks a lot for all the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support each function timeout?threading
2 participants