Upgrade to aiohttp v3 series and drop support for v1 #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* aiohttp v3 uses native async/await syntax and drops support for Python 3.5.2 or lower. * I think it would be reasonable enough to support latest two major versions of aiohttp: v2 and v3 series.
achimnol
commented
Feb 12, 2018
aioresponses/core.py
Outdated
| @@ -188,8 +188,7 @@ def match(self, method: str, url: str) -> 'ClientResponse': | |||
| del self._responses[i] | |||
| return resp | |||
|
|
|||
| @asyncio.coroutine | |||
| def _request_mock(self, orig_self: client.ClientSession, | |||
| async def _request_mock(self, orig_self: client.ClientSession, | |||
There was a problem hiding this comment.
This change is required because aiohttp treats this function as a "true" coroutine that has __await__ method.
2 similar comments
achimnol
added a commit
to lablup/backend.ai-common
that referenced
this pull request
Feb 12, 2018
* aiohttp.Timeout is dropped and now it is encouraged to use async_timeout directly. * Requires pnuckowski/aioresponses#87 or pnuckowski/aioresponses#89 to be merged.
|
@achimnol thanks for contribution :) 👍 |
|
fixes #88 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for Update for aiohttp v3.0 release #88.
aiohttp v3 uses native async/await syntax and drops support for
Python 3.5.2 or lower.
I think it would be reasonable enough to support latest two major
versions of aiohttp: v2 and v3 series.
(Of course the decision is up to the main author of this project!)