Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aiohttp 3 adaptation #87

Closed
wants to merge 2 commits into from
Closed

Conversation

decaz
Copy link
Contributor

@decaz decaz commented Feb 12, 2018

aiohttp version 3.0.0 was released and there is the new protocol parameter at StreamReader.__init__ so we need to fix StreamReader initializing.

There are also 2 issues to resolve withing this PR:

  • ImportError: No module named 'aiohttp.client_proto'
  • Ubiquitous exception: AttributeError: 'generator' object has no attribute '__await__' (maybe because aiohttp version 3.0.0 requires Python 3.5.3+)

@coveralls
Copy link

coveralls commented Feb 12, 2018

Coverage Status

Coverage remained the same at ?% when pulling 8a04b0f on decaz:feature/fix-aiohttp-3 into b16392d on pnuckowski:master.

@decaz decaz changed the title Fix StreamReader initializing aiohttp 3.0.0 adaptation Feb 12, 2018
@decaz decaz force-pushed the feature/fix-aiohttp-3 branch from 14256d5 to 8a04b0f Compare February 12, 2018 12:11
@decaz decaz changed the title aiohttp 3.0.0 adaptation aiohttp 3 adaptation Feb 12, 2018
achimnol added a commit to achimnol/aioresponses that referenced this pull request Feb 12, 2018
achimnol added a commit to lablup/backend.ai-common that referenced this pull request Feb 12, 2018
* aiohttp.Timeout is dropped and now it is encouraged to use
  async_timeout directly.

* Requires pnuckowski/aioresponses#87 or pnuckowski/aioresponses#89 to
  be merged.
@kowalski
Copy link
Contributor

@decaz I think that if you retried the failed build it would pass today. six 1.11.0 has been released, which fixes the problem with the setup.

Also I think it makes a lot of sense to add aiohttp3x deps in the tox testing matrix.

diff --git a/tox.ini b/tox.ini
index 6e3e270..d179974 100644
--- a/tox.ini
+++ b/tox.ini
@@ -2,7 +2,7 @@
 envlist =
     flake8,
     coverage,
-    {py34,py35}-aiohttp{10,11,12,master}
+    {py34,py35}-aiohttp{10,11,12,3x,master}
 skipsdist=True
 
 [testenv:flake8]
@@ -19,6 +19,7 @@ deps =
     aiohttp10: aiohttp>=1.0,<1.1
     aiohttp11: aiohttp>=1.1,<1.2
     aiohttp12: aiohttp>=1.2,<1.3
+    aiohttp3x: aiohttp>=3.0,<4.0
     aiohttpmaster: https://github.com/KeepSafe/aiohttp/archive/master.tar.gz
     -r{toxinidir}/requirements-dev.txt

@decaz
Copy link
Contributor Author

decaz commented Feb 16, 2018

Closing in favor of #89.

@decaz decaz closed this Feb 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants