-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change vid may cause resize and disable, Fix it. #25
Conversation
fixed |
But... would be easier to be freezed when cycling the vid |
Should have same behavior as change |
Not here. |
No. default.mp4 |
As I said above, this PR has nothing to do with freezing. All it does is restart the child process when it should be restarted. The problem is in the logic of the Piplup.Step.MV.-.mpv.2022-09-25.11-08-05_Trim.mp4 |
No this issue in the current master. 7b32934 default.mp4You ignored my comment here #25 (comment) |
TODO:
|
Sadly, debounce didn't fix the freezing of the video due to rotation, and I can't reproduce the freezing due to cycle vid |
We could use mp.register_idle() and then queue up changes in watch_changes() that then get sent after all changes were gathered. |
|
I don't quite understand why this is so, Change vid has always worked for me. And I think maybe it makes more sense to add debounce to spwan. |
Also works fine for me.
I can see same error when I set rotate. All the problems are due to the fact that the child processes and also the file system are unobservable asynchronous processes and we can only guess that it completes |
@hooke007 Does it still freeze under your test? If not, then is ready for review. |
Nopo. But the msg #25 (comment) is too noisy. Did a larger timeout would help? |
No idea until #11 (comment) is fixed.
I don't think so. |
I will look at this PR in detail tomorrow. |
|
Freezing issue happened again with the latest commit... |
Fix #21