Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

404 page for not found Block. #36

Closed
acravenho opened this issue Mar 6, 2018 · 8 comments
Closed

404 page for not found Block. #36

acravenho opened this issue Mar 6, 2018 · 8 comments
Assignees
@w-sanches
Labels
enhancement New feature or request priority: high High priority issues team: developer
Projects
Developers Section
Milestone
Kuala Lumpur

Comments

@acravenho
Copy link
Contributor

acravenho commented Mar 6, 2018 •
edited by gfreh

If the user navigates to the Block details page for a block that we have not indexed or is in the future we should show the block details page with the message that this block has not been processed yet.

Example:

Both links below show the block details page for a block that is the future, as seen on Etherscan and BlockScout:

Etherscan:
https://etherscan.io/block/125127248

BlockScout:
https://www.blockscout.com/eth/mainnet/blocks/125127248/transactions

Acceptance Criteria

The block details page for a block that we have not indexed yet or that is in the future should show no block related information, but just a message based on the following criteria:

  • If the block number is below the tip of the chain, the message should be:
    • "This block has not been processed yet".
  • If the block number is above the tip of the chain, the message should be:
    • "Easy Cowboy! This block doesn't exist yet!"

The image below is an example of how that page should be for the first case:
@acravenho acravenho added enhancement New feature or request team: contributor labels Mar 6, 2018
@acravenho acravenho added this to Icebox in Contributors Section Mar 13, 2018
@acravenho acravenho moved this from Icebox to ToDo in Contributors Section Mar 13, 2018
@acravenho acravenho added priority: low Low priority issues and removed Vienna to do labels Jul 18, 2018
@acravenho acravenho added this to the Kuala Lumpur milestone Jul 18, 2018
@acravenho acravenho changed the title Contributor sees 404 page for not found Block. 404 page for not found Block. Oct 4, 2018
@acravenho acravenho added team: developer priority: high High priority issues and removed priority: low Low priority issues team: contributor labels Oct 4, 2018
@acravenho acravenho removed this from ToDo in Contributors Section Oct 4, 2018
@acravenho acravenho added this to To Do in Developers Section Oct 4, 2018
@gfreh
Copy link

gfreh commented Oct 18, 2018 •
edited

@acravenho I've updated the description and added a suggestion for the block details page in the scenario described by this issue. WDYT?

I've also left a question.

@gfreh gfreh moved this from To Do to Refining in Developers Section Oct 18, 2018
@acravenho
Copy link
Contributor Author

@gfreh I think that looks good. I'm not sure I understand the question. As far as differentiating the design, yes, we should have the design different so the user knows this block doesn't really exist yet.

@gfreh
Copy link

gfreh commented Oct 18, 2018 •
edited

@acravenho By differentiating, I mean having a different message when the block is in the past, but we haven't indexed it yet vs. when the block is in the future. Not sure if that makes sense, though 😅

@acravenho
Copy link
Contributor Author

🤔 Yes, you're right. That would make sense. It's pretty easy and inexpensive to run the query for the tip of the chain. If below the tip we should provide the exact message that you have above.

@gfreh
Copy link

gfreh commented Oct 18, 2018

Nice! Do you have a suggestion for the message in the case the block number is above the tip?

@acravenho
Copy link
Contributor Author

😆 "Easy Cowboy! This block doesn't exist yet!"

@gfreh gfreh moved this from Refining to Ready to Do in Developers Section Oct 18, 2018
@brwatanabe brwatanabe mentioned this issue Nov 5, 2018
Closed
5 tasks
@w-sanches
Copy link
Contributor

I'll work on this one

@feliperenan feliperenan moved this from Ready to Do to In progress in Developers Section Nov 7, 2018
@w-sanches
Copy link
Contributor

@acravenho If i'm trying to access a not-indexed block by its hash, should I show that the block is not processed yet or that it does not exist?
I don't know if I can check if that hash is in the past or the future.

Example: https://blockscout.com/poa/core/blocks/0xf511fffa6403456a120edda6e1984a21e99ef2ca580f02f5367abc59bf16cddc/transactions

@w-sanches w-sanches mentioned this issue Nov 7, 2018
Merged
@w-sanches w-sanches moved this from In progress to In Review in Developers Section Nov 8, 2018
Developers Section automation moved this from In Review to Done Nov 9, 2018
Pedro-vk pushed a commit to Pedro-vk/blockscout that referenced this issue Nov 27, 2019
@mrsmkl
Merge pull request blockscout#36 from celo-org/mrsmkl/leaderboard
3957558 
Update to handle new transaction fields
shellteo pushed a commit to shellteo/blockscout that referenced this issue Jul 26, 2023
@Jaycelv
Merge pull request blockscout#36 from mantlenetworkio/albert/theme
7dc9436 
update theme color
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@w-sanches w-sanches

Labels
enhancement New feature or request priority: high High priority issues team: developer
Projects
Developers Section
  
Done
Milestone
Kuala Lumpur
Development

No branches or pull requests
3 participants
@gfreh @w-sanches @acravenho