Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction Details 404 page #38

Closed
5 tasks done
acravenho opened this issue Mar 6, 2018 · 18 comments · Fixed by #1071
Closed
5 tasks done

Transaction Details 404 page #38

acravenho opened this issue Mar 6, 2018 · 18 comments · Fixed by #1071
Assignees
Labels
enhancement New feature or request priority: high High priority issues team: developer
Milestone

Comments

@acravenho
Copy link
Contributor

acravenho commented Mar 6, 2018

If a transaction does not exist yet, we should not show a standard 404 page. Instead, we should show the TX details page but with a message stating that our node hasn't picked up the transaction yet and the page will update automatically when it does.

  1. If the user is on the correct route for the transaction details page but the tx hash is not found in the DB, we should show the normal transaction details page but with a message stating to please be patient while our nodes search for the transaction.
  2. We should subscribe to both pending transactions and incoming blocks to find the transaction hash.
  3. If the tx hash is found, refresh the page to show either the pending state or collated state.

Aceptance Criterias

  • Verify the TxHash in order to identify if the hash is or not valid and show to the user the correct page behavior:

    • For invalid hashes:
      • Show a warning message when the TxHash is invalid;
    • For pending transactions:
      • Show the TxDetails Page when it's valid but doesn't exist. Suggested sentence: Please be patient while our nodes search for the transaction.
      • Show a spinner for the pending transactions;
      • Show complementary information about the pending transaction process;
  • As soon as the txHash get processed the Hash's TxDetail Page needs to be refreshed with it's current state.

Tasks

  • Change controller to not redirect to the 404 page and insert the transaction hash when it is valid;
    • Send the hash to the realtime indexer to be indexed;
    • Alter view to show message of "Transaction not indexed yet."
  • Subscribe to pending "transactions" and "incoming blocks" websockets so when the transaction is indexed show in the view;
  • When the transaction hash is invalid show message: "Transaction hash invalid."
@acravenho acravenho added enhancement New feature or request team: contributor labels Mar 6, 2018
@acravenho acravenho added this to Icebox in Contributors Section Mar 13, 2018
@acravenho acravenho moved this from Icebox to ToDo in Contributors Section Mar 13, 2018
@acravenho acravenho removed Vienna enhancement New feature or request to do labels May 4, 2018
@acravenho acravenho added this to the Vienna milestone May 4, 2018
@acravenho acravenho added enhancement New feature or request priority: low Low priority issues and removed Vienna labels Jul 18, 2018
@acravenho acravenho modified the milestones: Vienna, Kuala Lumpur Jul 18, 2018
@acravenho acravenho changed the title As a Contributor, I should see a 404 page for Transaction Details if it does not exist. Transaction Details 404 page Oct 4, 2018
@acravenho acravenho added team: developer priority: high High priority issues and removed priority: low Low priority issues team: contributor labels Oct 4, 2018
@acravenho acravenho removed this from ToDo in Contributors Section Oct 4, 2018
@acravenho acravenho added this to To Do in Developers Section Oct 4, 2018
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 75.0 DAI (75.0 USD @ $1.0/DAI) attached to it as part of the Ethereum Community Fund via ECF Web 3.0 Infrastructure Fund fund.

@gitcoinbot
Copy link

gitcoinbot commented Oct 18, 2018

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 7 months, 1 week from now.
Please review their action plans below:

1) gusilverflame has been approved to start work.

  • create the templates for when the hash is invalid and when the transaction is not found
  • add to the controllers the cases when those new templates will be rendered
  • make the not found one auto refresh when the transaction is finally indexed

Learn more on the Gitcoin Issue Details page.

@aj07
Copy link

aj07 commented Oct 21, 2018

@acravenho I am facing setup issue for default configurations mentioned on Readme file (step 3). Is there any chat channel where we can connect you or with your team?

@acravenho
Copy link
Contributor Author

@aj07 Can you please provide more information on the issue? Depending upon which OS you're using and how you configured Postgres. If you installed Postgres using Homebrew you're most likely going to remove the username and password from apps/explorer/config/dev.secret.exs.

@acravenho
Copy link
Contributor Author

@aj07 You can join our Gitter chat located here https://gitter.im/poanetwork/blockscout if you would like to ask any questions.

1 similar comment
@acravenho
Copy link
Contributor Author

@aj07 You can join our Gitter chat located here https://gitter.im/poanetwork/blockscout if you would like to ask any questions.

@aj07
Copy link

aj07 commented Oct 24, 2018

I followed https://www.postgresql.org/download/linux/ubuntu/

apt-get install postgresql-10

I will ping on gitter

@acravenho
Copy link
Contributor Author

You have to provide us with the exact error message otherwise we don't have any idea how to help.

@gitcoinbot
Copy link

@aj07 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


@aj07 due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@aj07
Copy link

aj07 commented Oct 31, 2018

@gitcoinbot I am working on this

@gfreh gfreh moved this from To Do to Refining in Developers Section Nov 1, 2018
@brwatanabe
Copy link

@acravenho

Questions

  • Could we use a layout similar to that one we applied to the 404 block page?
    • If necessary, we could add a spinner as for the pending txs.
    • Also, we could add more information for the user, like Etherscan does here
  • What to do with invalid hashes? Etherscan shows a message for the user as seen here;
  • We should subscribe to both pending transactions and incoming blocks to find the transaction hash.
    • In this case, should the system prioritize the searched transaction to get it processed faster than usual?

@acravenho
Copy link
Contributor Author

acravenho commented Nov 5, 2018

@brwatanabe

  1. Yes, let's use a similar layout to the 404 block page, but with a spinner 👍 More information is always better, let's go for it.
  2. Yes, let's show a similar message as Etherscan for invalid hashes.
  3. Both pending and incoming blocks should be subscribed to. The realtime indexer should already be prioritizing this transaction. I'm not sure that there is much more that we can do to index it faster.

@feliperenan feliperenan moved this from Refining to Ready to Do in Developers Section Nov 6, 2018
@gitcoinbot
Copy link

@aj07 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@GustavoSantosFe GustavoSantosFe moved this from Ready to Do to In progress in Developers Section Nov 6, 2018
@GustavoSantosFe GustavoSantosFe self-assigned this Nov 6, 2018
@ghost ghost added the in progress label Nov 8, 2018
@brwatanabe brwatanabe moved this from In progress to In Review in Developers Section Nov 9, 2018
@mkosowsk
Copy link

@GuSilverFlame please apply for work on the Gitcoin detail page and you will be approved :)

@mkosowsk
Copy link

@GuSilverFlame you have been approved, please submit your work and you will be paid out. Thanks! 👍

Developers Section automation moved this from In Review to Done Nov 12, 2018
@ghost ghost removed the in progress label Nov 12, 2018
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 75.0 DAI (75.0 USD @ $1.0/DAI) has been submitted by:

  1. @GuSilverFlame

@mkosowsk please take a look at the submitted work:

  • PR by @GuSilverFlame

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 75.0 DAI (75.0 USD @ $1.0/DAI) attached to this issue has been approved & issued to @GuSilverFlame.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority: high High priority issues team: developer
Projects
Development

Successfully merging a pull request may close this issue.

7 participants