Fix no schema on GraphiQL #1050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Pull Request Test Coverage Report for Build b0f1b0a2-a1f5-4f71-a7f3-4ccf45178000
💛 - Coveralls |
KronicDeth
suggested changes
Nov 6, 2018
zachdaniel
approved these changes
Nov 6, 2018
There was a problem hiding this comment.
Agree with @KronicDeth that a comment would be good. Other than that, looks good :)
Why: * For the schema to be available at `/graphiql` * Issue link: #1042 This change addresses the need by: * Changing GraphQL `max_complexity` from 50 to 200 for introspection to be possible on GraphiQL. * Editing test that relied on a `max_complexity` of 50.
sabondano
force-pushed
the
sa-graphiql-no-schema-fix
branch
from
12f49b6
to
98b243a
Compare
KronicDeth
approved these changes
Nov 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1042
Motivation
/graphiqlChangelog
Bug Fixes
max_complexityfrom 50 to 200 for introspection tobe possible on GraphiQL.
max_complexityof 50.