Fix scheduling of latest block polling in Realtime Fetcher #1545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Timer is set using Elixir's `Process.send_after/3` method, which is incompatible with Erlang's `:timer` module.
Thus, `:timer.cancel` doesn't have any effect on it, and in fact returns `{:error, :badarg}`.
This causes more and more polling being scheduled after every websocket event, which might cause excessive flooding of a node with `eth_getBlockByNumber` requests after some running time.
ghost
assigned 
goodsoft
added
ready for review
Pull Request Test Coverage Report for Build 7c4d868f-8850-4438-b3dc-e1dc837ff375
💛 - Coveralls |
zachdaniel
approved these changes
Mar 10, 2019
vbaranov
approved these changes
Mar 11, 2019
ayrat555
approved these changes
Mar 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Timer is set using Elixir's
Process.send_after/3method, which is incompatible with Erlang's:timermodule.Thus,
:timer.canceldoesn't have any effect on it, and in fact returns{:error, :badarg}.This causes more and more polling being scheduled after every websocket event, which might cause excessive flooding of a node with
eth_getBlockByNumberrequests after some running time.