Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fallback to 2 evm versions #1915

Merged
merged 3 commits into from May 9, 2019
Merged

fallback to 2 evm versions #1915

merged 3 commits into from May 9, 2019

Conversation

ayrat555
Copy link
Contributor

@ayrat555 ayrat555 commented May 8, 2019

@ghost ghost assigned ayrat555 May 8, 2019
@ghost ghost added the in progress label May 8, 2019
vbaranov
vbaranov reviewed May 8, 2019
View reviewed changes
apps/explorer/lib/explorer/smart_contract/verifier.ex Outdated
@@ -17,13 +17,28 @@ defmodule Explorer.SmartContract.Verifier do
do: {:error, :contract_source_code}

def evaluate_authenticity(address_hash, params) do
evm_version = Map.get(params, "evm_version", "petersburg")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayrat555 could we change hardcoded "petersburg" here to the last element from CodeCompiler.allowed_evm_versions() ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in the future we could move the list of allowed EVM versions to ENV var #1918

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@vbaranov
Copy link
Member

vbaranov commented May 8, 2019

@ayrat555 btw, would you mind to update CHANGELOG with this the info from this PR?

@coveralls
Copy link

coveralls commented May 9, 2019 •
edited

Pull Request Test Coverage Report for Build def65eee-a1eb-4fba-9ae7-9f440af03fd1

  • 13 of 13 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 81.903%
Totals Coverage Status
Change from base Build 5280b26a-b92f-4349-ac9c-3063dd6ec688: 0.03%
Covered Lines: 4630
Relevant Lines: 5653
💛 - Coveralls

@vbaranov vbaranov merged commit 2e86815 into master May 9, 2019
@ghost ghost removed the in progress label May 9, 2019
@vbaranov vbaranov deleted the ab-fallback-evm branch May 9, 2019 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbaranov vbaranov vbaranov approved these changes

@zachdaniel zachdaniel zachdaniel approved these changes

Assignees

@ayrat555 ayrat555

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Contracts verification: fallback to 2 closest EVM versions
4 participants
@ayrat555 @vbaranov @coveralls @zachdaniel