-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fallback to 2 evm versions #1915
Conversation
@@ -17,13 +17,28 @@ defmodule Explorer.SmartContract.Verifier do | |||
do: {:error, :contract_source_code} | |||
|
|||
def evaluate_authenticity(address_hash, params) do | |||
evm_version = Map.get(params, "evm_version", "petersburg") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ayrat555 could we change hardcoded "petersburg" here to the last element from CodeCompiler.allowed_evm_versions()
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think in the future we could move the list of allowed EVM versions to ENV var #1918
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@ayrat555 btw, would you mind to update CHANGELOG with this the info from this PR? |
Pull Request Test Coverage Report for Build def65eee-a1eb-4fba-9ae7-9f440af03fd1
💛 - Coveralls |
fixes #1653 (comment)