Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSK theme fixes #2096

Merged
merged 6 commits into from
Jun 5, 2019
Merged

RSK theme fixes #2096

merged 6 commits into from
Jun 5, 2019

Conversation

gabitoesmiapodo
Copy link
Contributor

@gabitoesmiapodo gabitoesmiapodo commented Jun 4, 2019

Related to #1672

Motivation

Main changes were implemented on #1903 but I've found a few discrepancies that I addressed here. Links to the updated design can be found at #1672

Only @import "theme/base_variables"; and @import "rsk_variables"; should be uncommented in block_scout_web/assets/css/theme/_variables.scss for this to work.

New network selector present in the design won't be styled until it's implemented.

Fixes (screenshots are before the changes):

Screen Shot 2019-06-03 at 16 56 21

Corrected background gradient color and orientation.
Fixed block number color.

Screen Shot 2019-06-03 at 17 02 20

Corrected addresses' color.
Corrected dropdown button's color.

Screen Shot 2019-06-03 at 17 00 51

Corrected social icons' color.

Screen Shot 2019-06-04 at 11 13 23

Block list items color.

Changelog

Bug Fixes

  • RSK theme colors.

Checklist for your PR

  • I added an entry to CHANGELOG.md with this PR
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • I checked whether I should update the docs and did so if necessary

* master:
  Update CHANGELOG.md
@coveralls
Copy link

coveralls commented Jun 4, 2019

Pull Request Test Coverage Report for Build 47b4d2d6-a158-4da6-b773-c5cc0c2334cf

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 80.86%

Totals Coverage Status
Change from base Build 2ddffb09-f7f0-48c6-a78b-73f8832e738d: 0.0%
Covered Lines: 4816
Relevant Lines: 5956

💛 - Coveralls

vbaranov added a commit that referenced this pull request Jun 4, 2019
@vbaranov vbaranov merged commit cca0f1f into master Jun 5, 2019
@vbaranov vbaranov deleted the fix/rsk-theme-fixes branch June 5, 2019 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants