Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Claim reward updates #2838

Open
wants to merge 50 commits into
base: staking
from
Open

Claim reward updates #2838

wants to merge 50 commits into from

Conversation

@liberumed
Copy link

liberumed commented Nov 5, 2019

Motivation

Stakes snapshotting in the contract takes time and resources so it was decided to move it as part of the explorer app in blockscout so we can store snapshotted data in Postgress DB and populated it to the user differently.
Also, some contracts functions and events were removed or renamed so we need to update ABI as well.
This branch is working with "claim-reward" branch of "posdao-test-setup" repo

Changelog

  • Rename contract functions
  • Rename contract events
  • Delete contract functions
  • Add fields to StakingPool and StakingPoolsDelegator required for stakes snapshotting
  • Remove chain based stakes snapshotting porcess
  • Add blockscout based stakes snapshottting process
  • Display “Accounted Stake Amount” and “Current Reward Percent” in delegators list

TBD

  • Implement Frontend for validator info
  • Check function that have changed implementation
  • Chechk consequences from removing update_tokens process
liberumed added 3 commits Oct 22, 2019
@liberumed liberumed self-assigned this Nov 5, 2019
@coveralls

This comment has been minimized.

Copy link

coveralls commented Nov 5, 2019

Pull Request Test Coverage Report for Build d39bd57a-4e87-4c47-af77-2c9871850c33

  • 27 of 287 (9.41%) changed or added relevant lines in 15 files are covered.
  • 109 unchanged lines in 14 files lost coverage.
  • Overall coverage decreased (-3.9%) to 71.493%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/block_scout_web/lib/block_scout_web/controllers/stakes_controller.ex 0 1 0.0%
apps/explorer/lib/explorer/chain/import.ex 2 3 66.67%
apps/explorer/lib/explorer/chain/import/runner/staking_pools_delegators.ex 4 5 80.0%
apps/explorer/lib/explorer/chain/staking_pool.ex 1 2 50.0%
apps/block_scout_web/lib/block_scout_web/notifier.ex 0 2 0.0%
apps/explorer/lib/explorer/chain.ex 3 5 60.0%
apps/explorer/lib/explorer/chain/import/runner/staking_pools.ex 7 10 70.0%
apps/explorer/lib/explorer/staking/contract_reader.ex 0 19 0.0%
apps/explorer/lib/explorer/staking/stake_snapshotting.ex 0 44 0.0%
apps/block_scout_web/lib/block_scout_web/channels/stakes_channel.ex 0 73 0.0%
Files with Coverage Reduction New Missed Lines %
apps/ethereum_jsonrpc/lib/ethereum_jsonrpc/http/httpoison.ex 1 0.0%
apps/ethereum_jsonrpc/test/support/ethereum_jsonrpc/case/parity/http_websocket.ex 1 0.0%
apps/explorer/lib/explorer/chain.ex 1 77.49%
apps/explorer/lib/explorer/chain/import/runner/staking_pools_delegators.ex 1 68.42%
apps/indexer/lib/indexer/transform/addresses.ex 1 75.0%
apps/block_scout_web/lib/block_scout_web/channels/stakes_channel.ex 3 0.0%
apps/indexer/lib/indexer/block/catchup/bound_interval_supervisor.ex 3 85.19%
apps/indexer/lib/indexer/block/fetcher.ex 3 82.93%
apps/ethereum_jsonrpc/test/support/ethereum_jsonrpc/web_socket/case/parity.ex 4 0.0%
apps/explorer/lib/explorer/staking/contract_reader.ex 4 14.29%
Totals Coverage Status
Change from base Build 162d6e30-a5de-4650-b599-029928268f83: -3.9%
Covered Lines: 5214
Relevant Lines: 7293

💛 - Coveralls
@liberumed liberumed force-pushed the claim-reward branch 2 times, most recently from 8d9b559 to 0d9895f Nov 5, 2019
liberumed added 9 commits Nov 7, 2019
…es snapshotting
…gators list
@liberumed liberumed force-pushed the claim-reward branch from 0d9895f to 7048cfe Nov 11, 2019
@liberumed liberumed requested review from varasev and vbaranov Nov 11, 2019
@liberumed liberumed changed the title Claim reward updates - Claim reward updates Nov 11, 2019
varasev added 30 commits Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.