Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix long contracts names #2883

Merged
merged 6 commits into from
Feb 4, 2020
Merged

Fix long contracts names #2883

merged 6 commits into from
Feb 4, 2020

Conversation

maxaleks
Copy link
Collaborator

@maxaleks maxaleks commented Nov 27, 2019

@coveralls
Copy link

coveralls commented Nov 27, 2019

Pull Request Test Coverage Report for Build a179106f-b7fd-44ec-8de0-5ba4057cfd1d

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 75.361%

Totals Coverage Status
Change from base Build 81a76efa-c344-4d03-bd03-af7f5818371f: 0.01%
Covered Lines: 5423
Relevant Lines: 7196

💛 - Coveralls

Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxaleks

I think you need also check these types of tiles:
apps/block_scout_web/lib/block_scout_web/templates/transaction/_tile.html.eex (block page)
apps/block_scout_web/lib/block_scout_web/templates/internal_transaction/_tile.html.eex (Internal transactions tab)
apps/block_scout_web/lib/block_scout_web/templates/transaction/_token_transfer.html.eex (Token transfer tab)

@vbaranov vbaranov added the UI label Nov 29, 2019
@maxaleks
Copy link
Collaborator Author

maxaleks commented Dec 5, 2019

@vbaranov I haven't found other places where the contract name is used

@vbaranov vbaranov self-requested a review February 4, 2020 10:51
@vbaranov vbaranov merged commit 60624b6 into master Feb 4, 2020
@vbaranov vbaranov deleted the fix-long-contracts-names branch February 4, 2020 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants