Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix token instance QR code data #3016

Merged
merged 1 commit into from
Feb 19, 2020
Merged

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Feb 19, 2020

Motivation

URL behind QR-code on token instance page leads to 404 page

Changelog

Add set_path parameter to blockscout_url method and pass false in case of constructing URL for QR-code

Checklist for your Pull Request (PR)

@vbaranov vbaranov self-assigned this Feb 19, 2020
@vbaranov vbaranov force-pushed the vb-fix-token-instance-qr-code-data branch from 3ab2c74 to 2b44343 Compare February 19, 2020 14:14
@vbaranov vbaranov added the ready for review This PR is ready for reviews. label Feb 19, 2020
@vbaranov vbaranov force-pushed the vb-fix-token-instance-qr-code-data branch from 2b44343 to 28b25fb Compare February 19, 2020 14:18
@coveralls
Copy link

coveralls commented Feb 19, 2020

Pull Request Test Coverage Report for Build 50cd323e-29fa-4aaf-86f5-2f5cce3cbf6b

  • 3 of 5 (60.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.004%) to 75.371%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/block_scout_web/lib/block_scout_web/views/tokens/instance/overview_view.ex 0 2 0.0%
Totals Coverage Status
Change from base Build f166d46a-d41e-459a-9fb5-430df5084406: -0.004%
Covered Lines: 5432
Relevant Lines: 7207

💛 - Coveralls

@vbaranov vbaranov merged commit c7c379b into master Feb 19, 2020
@vbaranov vbaranov deleted the vb-fix-token-instance-qr-code-data branch February 19, 2020 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR is ready for reviews.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants