Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xDai logo dark theme fix #3317

Merged
merged 3 commits into from
Sep 28, 2020
Merged

xDai logo dark theme fix #3317

merged 3 commits into from
Sep 28, 2020

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Sep 28, 2020

Motivation

Fix smile xDai logo style for dark theme

Changelog

Header:
Screenshot 2020-09-28 at 21 43 06

Footer:
Screenshot 2020-09-28 at 21 43 11

Dark theme:
Screenshot 2020-09-28 at 22 48 27

Chore:

  • shorten logo text to prevent overlapping of the logo with menu items for some edge screen resolutions
  • Fix info icon location. Put it on the same line with the market cap value in mobile view:
    Screenshot 2020-09-28 at 11 07 13

Checklist for your Pull Request (PR)

@coveralls
Copy link

coveralls commented Sep 28, 2020

Pull Request Test Coverage Report for Build 2ba18749c94a343675df846cdbd7a40aa65ac95e-PR-3317

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+8.6%) to 74.529%

Totals Coverage Status
Change from base Build 84145676775f39d65f25218928ea15a9cf4cdb54: 8.6%
Covered Lines: 1978
Relevant Lines: 2654

💛 - Coveralls

@vbaranov vbaranov merged commit 31b530e into master Sep 28, 2020
@vbaranov vbaranov deleted the vb-dai-logo branch September 28, 2020 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants