Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix procedure of marking internal transactions as failed #3401

Merged
merged 2 commits into from
Oct 27, 2020

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Oct 27, 2020

Motivation

If a block has multiple transactions and block's first transaction is failed, Blockscout marks all internal transactions in that block as failed too even if their parent transactions are not failed.

Changelog

Fix function of searching failed parent trace to mark child traces as failed.

Checklist for your Pull Request (PR)

@vbaranov vbaranov changed the title Fix int txs error status Fix procedure of marking internal transactions as failed Oct 27, 2020
@coveralls
Copy link

coveralls commented Oct 27, 2020

Pull Request Test Coverage Report for Build 366363715d6e22d04d08fa6cb55c0c9529ab8ca8-PR-3401

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.9%) to 67.677%

Files with Coverage Reduction New Missed Lines %
test/block_scout_web/features/pages/chain_page.ex 1 90.0%
Totals Coverage Status
Change from base Build 6af67adf73b30e3ca06e11490c72b2df8df93dc5: -0.9%
Covered Lines: 2054
Relevant Lines: 3035

💛 - Coveralls

@vbaranov vbaranov merged commit 797b190 into master Oct 27, 2020
@vbaranov vbaranov deleted the vb-fix-int-txs-status branch October 27, 2020 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants