Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getsourcecode API endpoint: show data for unverified contract from verified contract with the same bytecode #3637

Merged
merged 2 commits into from
Feb 19, 2021

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Feb 16, 2021

Resolves #3632

Motivation

Display ABI and other data of verified contract at getsourcecode API endpoint for the contract, which is not verified but has the same bytecode.

Checklist for your Pull Request (PR)

@vbaranov vbaranov changed the title getsourcecode API endpoint: show data from verified contract getsourcecode API endpoint: show data for unverified contract from verified contract withh the same bytecode Feb 16, 2021
@vbaranov vbaranov changed the title getsourcecode API endpoint: show data for unverified contract from verified contract withh the same bytecode getsourcecode API endpoint: show data for unverified contract from verified contract with the same bytecode Feb 16, 2021
@coveralls
Copy link

coveralls commented Feb 16, 2021

Pull Request Test Coverage Report for Build 4a597efdb81b3b6a46e3c51aefe06b62994e5522-PR-3637

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-2.3%) to 64.585%

Files with Coverage Reduction New Missed Lines %
test/block_scout_web/features/pages/chain_page.ex 1 90.0%
lib/block_scout_web/controllers/chain/market_history_chart_controller.ex 2 71.43%
Totals Coverage Status
Change from base Build 71d3e40e7bf3c16c6fff4cfdbb3c625b15cdd9e9: -2.3%
Covered Lines: 2099
Relevant Lines: 3250

💛 - Coveralls

@vbaranov vbaranov merged commit 216a8e0 into master Feb 19, 2021
@vbaranov vbaranov deleted the vb-bytecode-twin-at-api branch February 19, 2021 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support of identical contracts' bytecode in API level
2 participants