Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rand::Rand is deprecated -- update rand version and Convert to distributions::Standard #145

Closed
c0gent opened this issue Jul 17, 2018 · 5 comments
Assignees

Comments

@c0gent
Copy link
Contributor

c0gent commented Jul 17, 2018

TODO

@c0gent c0gent self-assigned this Jul 17, 2018
@c0gent c0gent changed the title rand::Rand is deprecated -- Convert to rand::distributions::Standard rand::Rand is deprecated -- update rand version and Convert to distributions::Standard Jul 17, 2018
@afck
Copy link
Collaborator

afck commented Jul 18, 2018

The only obstacle with that is that pairing still uses rand 0.4, so I guess

let x: Fq = rand::random();

wouldn't work anymore?

@c0gent
Copy link
Contributor Author

c0gent commented Jul 18, 2018

I see. Ok well we might have to update it there too.

@mbr
Copy link
Contributor

mbr commented Jul 18, 2018

We (well, I) knew that rand::Rand was on the way out when I added it; I assumed we want to pick a rand (crate) version and stick to it. Using the same version as pairing seemed a logical choice.

I have no idea how easy it will be to get pairing updated to rand 0.5. Ideally, we might have gotten rid of the need for the Rand-Trait (mainly used in testing) by then.

@c0gent
Copy link
Contributor Author

c0gent commented Jul 18, 2018

Well I've updated most of my crates that use rand to 0.5. It's mostly a find and replace but we'll have to see. Not a high priority.

@afck
Copy link
Collaborator

afck commented Apr 25, 2019

We're using rand 0.6.5 now. Closing this.

@afck afck closed this as completed Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants