Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix libsecp256k1 compilation #415

Closed
ayrat555 opened this issue Sep 9, 2018 · 10 comments
Closed

fix libsecp256k1 compilation #415

ayrat555 opened this issue Sep 9, 2018 · 10 comments

Comments

@ayrat555
Copy link
Member

ayrat555 commented Sep 9, 2018

Currently, we are manually compiling libsecp256k1 in setup script https://github.com/poanetwork/mana/blob/master/bin/setup#L114

Potential solutions:

See also #413

@ghost
Copy link

ghost commented Oct 10, 2018

What do you think about coding the functionality in rust, and then porting it to elixir via rustler?

@ayrat555
Copy link
Member Author

@Lokraan I think that's a possible solution.

@ghost
Copy link

ghost commented Oct 10, 2018

@ayrat555 I'll start working on that then.

@ayrat555
Copy link
Member Author

ayrat555 commented Oct 10, 2018

it's ok with me
cc @masonforest @germsvel @MattMSumner

@igorbarinov
Copy link
Member

@ayrat555 I'll start working on that then.

@Lokraan are you sure? IMO it's very ambitious and time-consuming task to do

@ghost
Copy link

ghost commented Oct 10, 2018

@igorbarinov The code is already out there, I just have to port it to rust syntax.

@igorbarinov
Copy link
Member

@Lokraan do you plan to use https://github.com/ETCDEVTeam/libsecp256k1-rs ?

@ghost
Copy link

ghost commented Oct 10, 2018

@igorbarinov I can use that, I was planning on writing it manually.

@hayesgm
Copy link
Contributor

hayesgm commented Oct 29, 2018

Have you tried building with version https://hex.pm/packages/libsecp256k1/0.1.10? It should generally fix compilation issues.

@hayesgm hayesgm closed this as completed Nov 2, 2018
@hayesgm
Copy link
Contributor

hayesgm commented Nov 2, 2018

Marking as done with the upgrade to 0.1.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants