New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contributor see a Token tab in the Address page #410
Comments
@acravenho Based on the discussion we've just had at Gaslight's standup, we believe we should prioritize this issue. We've updated the scope in the comment above and removed the balance related parts for now because it depends on #514. For the
|
Do you think the number of transfers between that token and the account address should be included? I think this is a good metric to show. The rest of the items look accurate 👍 |
@acravenho do you mean in the Tokens tab? This is already in the acceptance criteria (it should be shown below the token name in the Token list). |
Perfect. I must have missed it. |
Besides the questions in the PR description, we thought of this one:
|
@lucasnar No, we should not display the tab. |
@acravenho two comments here: Firstly, we've split this issue in three as follows. This way, we believe we can reduce merge code faster and accelerate the feedback loop.
Also, there are some other questions in the issue's first comment. Would you mind taking a look at them, please? |
@gfreh I'm not seeing the questions you're referring to. |
As a
Contributor
, I want to see aToken
tab in theAddress Details
page, where I can see the list ofTokens
theAddress
holds, as well as see theToken Transfers
for each of thoseTokens
.https://projects.invisionapp.com/share/8EMX9IOR2V9#/screens/308371747
Acceptance Criteria
Tokens
tab in theAddress Details
page, where there should be a list with all theTokens
that specificAddress
has been involved in transfers.Token
, there should be possible to see the following information:Token
nameAddress
or part of it.Address
has been involved)Tokens
list.Out of Scope
Tasks
Refactor the token's list at the dropdown to use the new controller;(not needed anymore)The text was updated successfully, but these errors were encountered: