Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributor see a Token tab in the Address page #410

Closed
11 tasks done
igorffs opened this issue Jul 16, 2018 · 11 comments
Closed
11 tasks done

Contributor see a Token tab in the Address page #410

igorffs opened this issue Jul 16, 2018 · 11 comments
Assignees
Labels
enhancement New feature or request priority: medium Issues with a medium priority team: developer tokens
Milestone

Comments

@igorffs
Copy link
Contributor

igorffs commented Jul 16, 2018

As a Contributor, I want to see a Token tab in the Address Details page, where I can see the list of Tokens the Address holds, as well as see the Token Transfers for each of those Tokens.

https://projects.invisionapp.com/share/8EMX9IOR2V9#/screens/308371747

Acceptance Criteria

  • Add a Tokens tab in the Address Details page, where there should be a list with all the Tokens that specific Address has been involved in transfers.
    • For each Token, there should be possible to see the following information:
      • Token name
        • If the token has no name, display the token Address or part of it.
      • Number of transfers (in which the associated Address has been involved)
      • The token type (ERC-20 or ERC-721)
    • There should be possible to paginate the Tokens list.

Out of Scope

Tasks

  • Create a query to get all tokens an address interacted with;
  • Build a query that counts the token transfers from the given address (maybe we can reuse the query above);
  • Create a controller to centralize the list of tokens given an address;
  • Refactor the token's list at the dropdown to use the new controller; (not needed anymore)
  • Create a new tab on the Address Details page;
  • Build the front-end;
    • List the tokens that address has interacted with. Each token goes on its own card, with the following information:
    • Token name, or token address if it has no name;
    • Number of transfers that involved both that address and that token;
    • Add pagination;
    • Add links.
@igorffs igorffs created this issue from a note in Developers Section (To Do) Jul 16, 2018
@acravenho acravenho added this to the Vienna milestone Jul 16, 2018
@acravenho acravenho added the enhancement New feature or request label Jul 16, 2018
@igorffs igorffs changed the title Developers see a Token tab in the Contract Details page Developers see a Token tab in the Address page Jul 16, 2018
@igorffs igorffs changed the title Developers see a Token tab in the Address page Contributor see a Token tab in the Address page Jul 16, 2018
@acravenho acravenho added the priority: medium Issues with a medium priority label Jul 18, 2018
@gfreh gfreh mentioned this issue Aug 9, 2018
5 tasks
@gfreh gfreh moved this from To Do to Refining in Developers Section Aug 10, 2018
@gfreh
Copy link

gfreh commented Aug 15, 2018

@acravenho Based on the discussion we've just had at Gaslight's standup, we believe we should prioritize this issue. We've updated the scope in the comment above and removed the balance related parts for now because it depends on #514.

For the balance related parts, we believe the best approach would be creating a new issue with the following description:

  • For each Token, there should be possible to see the following information:
    • Token balance (for the associated address) followed by the token symbol.
      • For ERC20 Tokens, the balance should be formatted as currency (thousands and decimal separators) considering the token's decimals info (if there is no decimals info, display the formatted amount). Example: 999,000.02 FREH
      • For ERC721 Tokens, the balance of non-fungible tokens. Example: 803,843 CK
      • In case the Token has no symbol, show nothing next to the amount.

@acravenho
Copy link
Contributor

acravenho commented Aug 15, 2018

Do you think the number of transfers between that token and the account address should be included? I think this is a good metric to show.

The rest of the items look accurate 👍

@gfreh
Copy link

gfreh commented Aug 16, 2018

@acravenho do you mean in the Tokens tab? This is already in the acceptance criteria (it should be shown below the token name in the Token list).

@acravenho
Copy link
Contributor

Perfect. I must have missed it.

@lucasnar
Copy link
Contributor

Besides the questions in the PR description, we thought of this one:

  • If the address hasn't interacted with any tokens, should we display this tab? If yes, what should be inside it?

@acravenho
Copy link
Contributor

@lucasnar No, we should not display the tab.

@gfreh
Copy link

gfreh commented Aug 16, 2018

@acravenho two comments here:

Firstly, we've split this issue in three as follows. This way, we believe we can reduce merge code faster and accelerate the feedback loop.

  1. This one will handle displaying the tokens list with the number of transfers.
  2. Contributor can filter the Token Transfers by Token in the Token tab at the Address page #561 will handle clicking on a token item and displaying the list of token transfers.
  3. Contributor sees the Token balance for each Token listed in the Token tab for the Address page #564 will handle displaying the token balances in the list (this also depends on Index Tokens balances per Address #514).

Also, there are some other questions in the issue's first comment. Would you mind taking a look at them, please?

@acravenho
Copy link
Contributor

@gfreh I'm not seeing the questions you're referring to.

@gfreh gfreh closed this as completed Aug 16, 2018
Developers Section automation moved this from Ready to Do to Done Aug 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority: medium Issues with a medium priority team: developer tokens
Projects
Development

No branches or pull requests

4 participants