-
Notifications
You must be signed in to change notification settings - Fork 64
/
proxy_storage_upgrade_test.js
306 lines (277 loc) · 15.1 KB
/
proxy_storage_upgrade_test.js
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
let PoaNetworkConsensus = artifacts.require('./mockContracts/PoaNetworkConsensusMock');
let KeysManager = artifacts.require('./mockContracts/KeysManagerMock');
let ProxyStorageMock = artifacts.require('./mockContracts/ProxyStorageMock');
let ProxyStorageNew = artifacts.require('./upgradeContracts/ProxyStorageNew');
let ValidatorMetadata = artifacts.require('./ValidatorMetadata');
let BallotsStorage = artifacts.require('./BallotsStorage');
let VotingToChangeKeys = artifacts.require('./VotingToChangeKeys');
let VotingToChangeMinThreshold = artifacts.require('./VotingToChangeMinThreshold');
let VotingToChangeProxy = artifacts.require('./VotingToChangeProxyAddress');
let VotingToManageEmissionFunds = artifacts.require('./VotingToManageEmissionFunds');
let RewardByBlock = artifacts.require('./RewardByBlock');
let EternalStorageProxy = artifacts.require('./mockContracts/EternalStorageProxyMock');
const ERROR_MSG = 'VM Exception while processing transaction: revert';
require('chai')
.use(require('chai-as-promised'))
.use(require('chai-bignumber')(web3.BigNumber))
.should();
let masterOfCeremony;
let keysManager, keysManagerEternalStorage;
let proxyStorage, proxyStorageEternalStorage;
let validatorMetadata, validatorMetadataEternalStorage;
let ballotsStorage, ballotsEternalStorage;
let votingToChangeKeys, votingToChangeKeysEternalStorage;
let votingToChangeMinThreshold, votingToChangeMinThresholdEternalStorage;
let votingToChangeProxy, votingToChangeProxyEternalStorage;
let votingToManageEmissionFunds, votingToManageEmissionFundsEternalStorage;
let rewardByBlock, rewardByBlockEternalStorage;
contract('ProxyStorage upgraded [all features]', function (accounts) {
beforeEach(async () => {
masterOfCeremony = accounts[0];
poaNetworkConsensus = await PoaNetworkConsensus.new(masterOfCeremony, []);
proxyStorage = await ProxyStorageMock.new();
proxyStorageEternalStorage = await EternalStorageProxy.new(0, proxyStorage.address);
proxyStorage = await ProxyStorageMock.at(proxyStorageEternalStorage.address);
await proxyStorage.init(poaNetworkConsensus.address).should.be.fulfilled;
(await proxyStorageEternalStorage.getProxyStorage.call()).should.be.equal(
proxyStorageEternalStorage.address
);
const proxyStorageNew = await ProxyStorageNew.new();
await proxyStorageEternalStorage.setProxyStorage(accounts[6]);
const {logs} = await proxyStorageEternalStorage.upgradeTo(proxyStorageNew.address, {from: accounts[6]});
logs[0].event.should.be.equal("Upgraded");
await proxyStorageEternalStorage.setProxyStorage(proxyStorageEternalStorage.address);
proxyStorage = await ProxyStorageNew.at(proxyStorageEternalStorage.address);
keysManager = await KeysManager.new();
keysManagerEternalStorage = await EternalStorageProxy.new(proxyStorage.address, keysManager.address);
keysManager = await KeysManager.at(keysManagerEternalStorage.address);
validatorMetadata = await ValidatorMetadata.new();
validatorMetadataEternalStorage = await EternalStorageProxy.new(proxyStorage.address, validatorMetadata.address);
ballotsStorage = await BallotsStorage.new();
ballotsEternalStorage = await EternalStorageProxy.new(proxyStorage.address, ballotsStorage.address);
votingToChangeKeys = await VotingToChangeKeys.new();
votingToChangeKeysEternalStorage = await EternalStorageProxy.new(proxyStorage.address, votingToChangeKeys.address);
votingToChangeMinThreshold = await VotingToChangeMinThreshold.new();
votingToChangeMinThresholdEternalStorage = await EternalStorageProxy.new(proxyStorage.address, votingToChangeMinThreshold.address);
votingToChangeProxy = await VotingToChangeProxy.new();
votingToChangeProxyEternalStorage = await EternalStorageProxy.new(proxyStorage.address, votingToChangeProxy.address);
votingToManageEmissionFunds = await VotingToManageEmissionFunds.new();
votingToManageEmissionFundsEternalStorage = await EternalStorageProxy.new(proxyStorage.address, votingToManageEmissionFunds.address);
rewardByBlock = await RewardByBlock.new();
rewardByBlockEternalStorage = await EternalStorageProxy.new(proxyStorage.address, rewardByBlock.address);
})
describe('#constructor', async () => {
it('sets PoA', async () => {
poaNetworkConsensus.address.should.be.equal(
await proxyStorage.getPoaConsensus.call()
);
})
})
describe('#initializeAddresses', async () => {
it('sets all addresses', async () => {
await proxyStorage.initializeAddresses(
keysManagerEternalStorage.address,
votingToChangeKeysEternalStorage.address,
votingToChangeMinThresholdEternalStorage.address,
votingToChangeProxyEternalStorage.address,
votingToManageEmissionFundsEternalStorage.address,
ballotsEternalStorage.address,
validatorMetadataEternalStorage.address,
rewardByBlockEternalStorage.address,
{from: accounts[2]}
).should.be.rejectedWith(ERROR_MSG);
const {logs} = await proxyStorage.initializeAddresses(
keysManagerEternalStorage.address,
votingToChangeKeysEternalStorage.address,
votingToChangeMinThresholdEternalStorage.address,
votingToChangeProxyEternalStorage.address,
votingToManageEmissionFundsEternalStorage.address,
ballotsEternalStorage.address,
validatorMetadataEternalStorage.address,
rewardByBlockEternalStorage.address
).should.be.fulfilled;
keysManagerEternalStorage.address.should.be.equal(
await proxyStorage.getKeysManager.call()
);
votingToChangeKeysEternalStorage.address.should.be.equal(
await proxyStorage.getVotingToChangeKeys.call()
);
votingToChangeMinThresholdEternalStorage.address.should.be.equal(
await proxyStorage.getVotingToChangeMinThreshold.call()
);
votingToChangeProxyEternalStorage.address.should.be.equal(
await proxyStorage.getVotingToChangeProxy.call()
);
votingToManageEmissionFundsEternalStorage.address.should.be.equal(
await proxyStorage.getVotingToManageEmissionFunds.call()
);
ballotsEternalStorage.address.should.be.equal(
await proxyStorage.getBallotsStorage.call()
);
validatorMetadataEternalStorage.address.should.be.equal(
await proxyStorage.getValidatorMetadata.call()
);
rewardByBlockEternalStorage.address.should.be.equal(
await proxyStorage.getRewardByBlock.call()
);
logs[0].event.should.be.equal('ProxyInitialized');
logs[0].args.keysManagerEternalStorage.should.be.equal(keysManagerEternalStorage.address);
logs[0].args.votingToChangeKeysEternalStorage.should.be.equal(votingToChangeKeysEternalStorage.address);
logs[0].args.votingToChangeMinThresholdEternalStorage.should.be.equal(votingToChangeMinThresholdEternalStorage.address);
logs[0].args.votingToChangeProxyEternalStorage.should.be.equal(votingToChangeProxyEternalStorage.address);
logs[0].args.votingToManageEmissionFundsEternalStorage.should.be.equal(votingToManageEmissionFundsEternalStorage.address);
logs[0].args.ballotsStorageEternalStorage.should.be.equal(ballotsEternalStorage.address);
logs[0].args.validatorMetadataEternalStorage.should.be.equal(validatorMetadataEternalStorage.address);
logs[0].args.rewardByBlockEternalStorage.should.be.equal(rewardByBlockEternalStorage.address);
})
it('prevents Moc to call it more than once', async () => {
false.should.be.equal(await proxyStorage.mocInitialized.call());
const {logs} = await proxyStorage.initializeAddresses(
keysManagerEternalStorage.address,
votingToChangeKeysEternalStorage.address,
votingToChangeMinThresholdEternalStorage.address,
votingToChangeProxyEternalStorage.address,
votingToManageEmissionFundsEternalStorage.address,
ballotsEternalStorage.address,
validatorMetadataEternalStorage.address,
rewardByBlockEternalStorage.address
).should.be.fulfilled;
true.should.be.equal(await proxyStorage.mocInitialized.call());
await proxyStorage.initializeAddresses(
keysManagerEternalStorage.address,
votingToChangeKeysEternalStorage.address,
votingToChangeMinThresholdEternalStorage.address,
votingToChangeProxyEternalStorage.address,
votingToManageEmissionFundsEternalStorage.address,
ballotsEternalStorage.address,
validatorMetadataEternalStorage.address,
rewardByBlockEternalStorage.address
).should.be.rejectedWith(ERROR_MSG);
})
})
describe('#setContractAddress', async () => {
beforeEach(async () => {
await proxyStorage.initializeAddresses(
keysManagerEternalStorage.address,
votingToChangeKeysEternalStorage.address,
votingToChangeMinThresholdEternalStorage.address,
votingToChangeProxyEternalStorage.address,
votingToManageEmissionFundsEternalStorage.address,
ballotsEternalStorage.address,
validatorMetadataEternalStorage.address,
rewardByBlockEternalStorage.address,
{from: masterOfCeremony}
).should.be.fulfilled;
})
it('can only be called from votingToChangeProxy address', async () => {
await proxyStorage.setContractAddress(1, accounts[2], {from: accounts[0]}).should.be.rejectedWith(ERROR_MSG);
await proxyStorage.setVotingToChangeProxyMock(accounts[4]);
await setContractAddress(1, accounts[2], true, {from: accounts[4]});
await proxyStorage.setVotingToChangeProxyMock(votingToChangeProxyEternalStorage.address);
})
it('cannot be set to 0x0 address', async () => {
await proxyStorage.setVotingToChangeProxyMock(accounts[4]);
await setContractAddress(1, '0x0000000000000000000000000000000000000000', false, {from: accounts[4]});
await proxyStorage.setVotingToChangeProxyMock(votingToChangeProxyEternalStorage.address);
})
it('sets keysManager', async () => {
let keysManagerNew = await KeysManager.new();
await proxyStorage.setVotingToChangeProxyMock(accounts[4]);
await setContractAddress(1, keysManagerNew.address, true, {from: accounts[4]});
await proxyStorage.setVotingToChangeProxyMock(votingToChangeProxyEternalStorage.address);
let eternalProxyAddress = await proxyStorage.getKeysManager.call();
let eternalProxy = await EternalStorageProxy.at(eternalProxyAddress);
keysManagerNew.address.should.be.equal(
await eternalProxy.implementation.call()
);
})
it('sets votingToChangeKeys', async () => {
let votingToChangeKeysNew = await VotingToChangeKeys.new();
await proxyStorage.setVotingToChangeProxyMock(accounts[4]);
await setContractAddress(2, votingToChangeKeysNew.address, true, {from: accounts[4]});
await proxyStorage.setVotingToChangeProxyMock(votingToChangeProxyEternalStorage.address);
let eternalProxyAddress = await proxyStorage.getVotingToChangeKeys.call();
let eternalProxy = await EternalStorageProxy.at(eternalProxyAddress);
votingToChangeKeysNew.address.should.be.equal(
await eternalProxy.implementation.call()
)
})
it('sets votingToChangeMinThreshold', async () => {
let votingToChangeMinThresholdNew = await VotingToChangeMinThreshold.new();
await proxyStorage.setVotingToChangeProxyMock(accounts[4]);
await setContractAddress(3, votingToChangeMinThresholdNew.address, true, {from: accounts[4]});
await proxyStorage.setVotingToChangeProxyMock(votingToChangeProxyEternalStorage.address);
let eternalProxyAddress = await proxyStorage.getVotingToChangeMinThreshold.call();
let eternalProxy = await EternalStorageProxy.at(eternalProxyAddress);
votingToChangeMinThresholdNew.address.should.be.equal(
await eternalProxy.implementation.call()
)
})
//it('sets votingToChangeProxy', async () => {
// see voting_to_change_proxy_test.js
//})
it('sets ballotsStorage', async () => {
let ballotsStorageNew = await BallotsStorage.new();
await proxyStorage.setVotingToChangeProxyMock(accounts[4]);
await setContractAddress(5, ballotsStorageNew.address, true, {from: accounts[4]});
await proxyStorage.setVotingToChangeProxyMock(votingToChangeProxyEternalStorage.address);
let eternalProxyAddress = await proxyStorage.getBallotsStorage.call();
let eternalProxy = await EternalStorageProxy.at(eternalProxyAddress);
ballotsStorageNew.address.should.be.equal(
await eternalProxy.implementation.call()
)
})
it('sets poaConsensus', async () => {
await proxyStorage.setVotingToChangeProxyMock(accounts[4]);
await setContractAddress(6, accounts[5], true, {from: accounts[4]});
await proxyStorage.setVotingToChangeProxyMock(votingToChangeProxyEternalStorage.address);
accounts[5].should.be.equal(
await proxyStorage.getPoaConsensus.call()
)
})
it('sets validatorMetadata', async () => {
let validatorMetadataNew = await ValidatorMetadata.new();
await proxyStorage.setVotingToChangeProxyMock(accounts[4]);
await setContractAddress(7, validatorMetadataNew.address, true, {from: accounts[4]});
await proxyStorage.setVotingToChangeProxyMock(votingToChangeProxyEternalStorage.address);
let eternalProxyAddress = await proxyStorage.getValidatorMetadata.call();
let eternalProxy = await EternalStorageProxy.at(eternalProxyAddress);
validatorMetadataNew.address.should.be.equal(
await eternalProxy.implementation.call()
)
})
it('changes proxyStorage (itself) implementation', async () => {
const oldVersion = await proxyStorageEternalStorage.version.call();
const newVersion = oldVersion.add(1);
let proxyStorageNew = await ProxyStorageMock.new();
await proxyStorage.setVotingToChangeProxyMock(accounts[4]);
await setContractAddress(8, proxyStorageNew.address, true, {from: accounts[4]});
await proxyStorage.setVotingToChangeProxyMock(votingToChangeProxyEternalStorage.address);
proxyStorageNew.address.should.be.equal(
await proxyStorageEternalStorage.implementation.call()
);
newVersion.should.be.bignumber.equal(
await proxyStorageEternalStorage.version.call()
);
})
it('sets rewardByBlock', async () => {
const rewardByBlockNew = await RewardByBlock.new();
await proxyStorage.setVotingToChangeProxyMock(accounts[4]);
await setContractAddress(9, rewardByBlockNew.address, true, {from: accounts[4]});
await proxyStorage.setVotingToChangeProxyMock(votingToChangeProxyEternalStorage.address);
const eternalProxyAddress = await proxyStorage.getRewardByBlock.call();
const eternalProxy = await EternalStorageProxy.at(eternalProxyAddress);
rewardByBlockNew.address.should.be.equal(
await eternalProxy.implementation.call()
)
})
})
})
async function setContractAddress(_contractType, _contractAddress, _shouldBeSuccessful, options) {
const result = await proxyStorage.setContractAddress(_contractType, _contractAddress, options);
if (_shouldBeSuccessful) {
result.logs[0].event.should.be.equal("AddressSet");
} else {
result.logs.length.should.be.equal(0);
}
}