Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Fix) VotingToManageEmissionFunds.canBeFinalizedNow function #187

Open
varasev opened this issue Sep 18, 2018 · 0 comments
Open

(Fix) VotingToManageEmissionFunds.canBeFinalizedNow function #187

varasev opened this issue Sep 18, 2018 · 0 comments
Assignees

Comments

@varasev
Copy link
Contributor

varasev commented Sep 18, 2018

Problem: The VotingToManageEmissionFunds.canBeFinalizedNow function doesn't allow to finalize an active ballot if all validators are voted during the 15-minutes period of time (canceling threshold) right after a ballot is created. In that case, finalization is only possible after ballot's endTime is reached.

Solution: Replace the condition if (isActive(_id)) return false; with if (isActive(_id) && getTotalVoters(_id) < validatorsLength) return false; here:

- it would allow finalizing a ballot before its endTime is reached even if all validators voted within 15-minutes canceling threshold right after the ballot was created.

@varasev varasev self-assigned this Sep 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant