Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gas allocation at 0 #206

Closed
freshbtcer opened this issue Oct 3, 2017 · 11 comments
Closed

Gas allocation at 0 #206

freshbtcer opened this issue Oct 3, 2017 · 11 comments

Comments

@freshbtcer
Copy link

Processing 3 tier ICO, at least 6 contracts needed to be signed where gas limit was not filled in, was unsure of amount and might be a reason why contracts failed not knowing the amount of gas to send to each one.

@vbaranov
Copy link
Collaborator

vbaranov commented Oct 3, 2017

We can't reproduce the issue with 3-tier contract.
Could you reproduce it to share the video with us? Or to point us, what parameters of crowdsale you've set?

@freshbtcer
Copy link
Author

It seems to only do it deploying to main network. All my test runs went through, but when I tried deploying the contract to main network is when at least a third of the transactions popped up to be signed where no gas input was entered, I had to enter a guess, I am not a programmer and not very knowledgeable when it comes to contracts, which is why I was trying to use this setup. I did notice however, these contracts are still using "throw" which means they aren't updated. Perhaps, it may be a good idea to get some updated contracts to work with this and this could be a great platform to launch ICOs

@freshbtcer
Copy link
Author

https://pastebin.com/d0J7dsBe

while running icowizard locally there are some errors, check out the paste bin for some of the information.. I can get the whole thing if needed, but this one was run in a multiplexer so I couldn't scroll.

@igorbarinov
Copy link
Member

I did notice however, these contracts are still using "throw" which means they aren't updated.

it's ok. we use proven TokenMarket contracts as a base. We will incrementally update them and include Safemath from OpenZeppelin in the future.

@freshbtcer
Copy link
Author

is there a chat channel you reside in? gitter, irc, slack? I am attemmpting another single tier and it came up with a transaction with 36 bytes of data gas limit set at 0 and gas price at 21... i have a screen shot of it but its on my other computer.. lmk

@igorbarinov
Copy link
Member

@freshbtcer we have a telegram chat here https://t.me/oraclesnetwork

@vbaranov
Copy link
Collaborator

vbaranov commented Oct 4, 2017

while running icowizard locally there are some errors, check out the paste bin for some of the >information.. I can get the whole thing if needed, but this one was run in a multiplexer so I couldn't >scroll.

These warnings don't affect ICO wizard logic. We should ignore them.

@freshbtcer if you have any screenshot or video describing your problem, it'll be very helpful to solve it. Or point us to the broken tx in the mainnet.

@vbaranov
Copy link
Collaborator

vbaranov commented Oct 6, 2017

@freshbtcer could you check https://wizard-stage.oracles.org/ ? Are you faced with this bug there?
If it is fixed there, we'll merge it to the main branch.

@vbaranov
Copy link
Collaborator

vbaranov commented Oct 7, 2017

Anyway, we merged this fix to https://wizard.oracles.org/. We'll appreciate your feedback.

@freshbtcer
Copy link
Author

Hey, sorry didn't get back to you sooner. I tried it out on the testnet and all the gas worked out and it deployed, I just didn't get to test it out because got called away to help with the kids and forgot about it. It happened on the main net though, I will try again soon let you know.

@vbaranov
Copy link
Collaborator

We have repaired the life cycle of ICO Wizard in mainnet. Thank you for the report!

@vbaranov vbaranov reopened this Oct 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants