Fix Travis coverage test run issue #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akolotov
approved these changes
Aug 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From time to time the task that run the coverage test in Travis failed with the error
TypeError: Cannot read property 'number' of null. Triggering a re-build fixed the task, sometimes you needed to trigger the re-build twice to make it work.The task fails because of the following issue MetaMask/web3-provider-engine#313 in
web3-provider-enginepackage. To fix it, I used the version that is included inside@0x/sol-coveragewhich is a previous version and seems to work fine.I run 4 builds of the task and it succeeded in all the cases.
Also fixed the directory of
FeeManagerMockcontract that probably was incorrectly included in an old directory in some merge.