Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add permit feature to token contract #410

Merged
merged 4 commits into from
May 4, 2020
Merged

Add permit feature to token contract #410

merged 4 commits into from
May 4, 2020

Conversation

varasev
Copy link
Contributor

@varasev varasev commented Apr 29, 2020

This PR adds permit feature to the token contract.

@varasev varasev requested a review from akolotov April 29, 2020 12:46
@varasev
Copy link
Contributor Author

varasev commented Apr 29, 2020

Travis shows some issue with ethUtil package. I will take a look.

@varasev
Copy link
Contributor Author

varasev commented May 4, 2020

@k1rill-fedoseev Could you please take a look at one of the unit tests related to DSR. Travis caught the following mismatch:

657 passing (28m)
  1 failing
  1) Contract: ForeignBridge_ERC20_to_Native
       chai token
         Zero DSR
           should allow to executeSignatures after pay interest:
      AssertionError: expected '7400000000000000004' to be less than '7400000000000000000'
      + expected - actual
      -7400000000000000004
      +7400000000000000000
      
      at Context.it (test/erc_to_native/foreign_bridge.test.js:2207:66)
      at process._tickCallback (internal/process/next_tick.js:68:7)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants