Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: modified circle UI #55

Conversation

mobile-simformsolutions

-removed depricated metods
-added new props for making component more usable

return {value: prevState.value}
}
else return null;
};
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be better like this:

 return nextProps.value !== prevState.value ? { value: prevState.value } : null;

or

 if (nextProps.value !== prevState.value) {
      return {value: prevState.value}
 } else {
      return null;
 }

And code style isn't right around line 75;

@poberwong
Copy link
Owner

Considering about many "pull request", I determinate to develop 2.0 to upgrade to react-native@latest.

Thanks for your contribution.

2.0 will have large, break changes and I will try my best to keep old api to reduce upgrading-risks

@poberwong poberwong closed this Sep 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants