Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom style container stager #10

Closed
wants to merge 3 commits into from
Closed

Custom style container stager #10

wants to merge 3 commits into from

Conversation

medeirosfalante
Copy link

No description provided.

@pocesar
Copy link
Owner

pocesar commented Oct 27, 2018

thanks for the PR, I'll fix the tests for RN 0.57 and will merge this (but note that "style" should be style?: StyleProps<ViewStyle>)

EDIT: seems like RN has been failing on windows for a while, won't be able to update the code while they don't fix the support for it facebook/react-native/issues/20460

suggestion @pocesar fix the types for style props
@medeirosfalante
Copy link
Author

thanks for the PR, I'll fix the tests for RN 0.57 and will merge this (but note that "style" should be style?: StyleProps<ViewStyle>)

EDIT: seems like RN has been failing on windows for a while, won't be able to update the code while they don't fix the support for it facebook/react-native/issues/20460

Of course i'ii do make a new pull with fix type define

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants