Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pock closes immediately on launching #15

Closed
ajitzero opened this issue Mar 26, 2019 · 16 comments
Closed

Pock closes immediately on launching #15

ajitzero opened this issue Mar 26, 2019 · 16 comments
Labels
Milestone

Comments

@ajitzero
Copy link

ajitzero commented Mar 26, 2019

When I launch Pock, it momentarily shows the dock on my Touchbar but disappears under 1 second. I haven't been able to make it work at all.

Clicking on an app through the Touchbar before it disappears works.

I'm on Mac OS X 10.14.2 and will be updating it this weekend. I'll update this issue if there is any change after the update. I'm on Mac OS X 10.14.4 (MBP 15-inch 2018) and there's no change.

(I didn't know about Docker previously so I haven’t been able to follow the discussion here.)

Crash file (renamed *.crash to *.txt for GitHub): Pock_2019-03-27-020039_Origins.txt

@pigigaldi pigigaldi added the bug label Mar 26, 2019
@wtlyu
Copy link

wtlyu commented Mar 28, 2019

same issue here

@remus-b
Copy link

remus-b commented Mar 28, 2019

Same here. Doesn't work. I'm on 10.14.3

@pigigaldi
Copy link
Collaborator

Thanks for the feedbacks, I’ll check this issue asap!

@sergiootorre
Copy link

Even when i go to preferences and choose to launch at login, it doesn't save. Pock closes everytime i lock my screen. It's a great and congrats for that but for now i had to put it at my dock so that i can launch it. ;)

@ghost
Copy link

ghost commented Mar 28, 2019

I'm having the same issue. Attached my crash file in case it helps! Looks pretty similar to AjitZero’s.
Pock_2019-03-28-131028_Amethyst.txt

@tuchief
Copy link

tuchief commented Mar 29, 2019

10.14.4 also has the same problem

@Tatsh
Copy link

Tatsh commented Mar 29, 2019

The fix is:

diff --git a/Pock/Widgets/Dock/PockUtilities.swift b/Pock/Widgets/Dock/PockUtilities.swift
index 6513250..84e1a2b 100644
--- a/Pock/Widgets/Dock/PockUtilities.swift
+++ b/Pock/Widgets/Dock/PockUtilities.swift
@@ -87,7 +87,7 @@ public class PockUtilities {

             /// Add bundle identifier to returnable array.
             let dockItem = PockItem(label: label, bundleIdentifier: bundleIdentifier, icon: PockUtilities.ge
tIcon(forBundleIdentifier: bundleIdentifier))
-            returnable.insert(dockItem, at: ind)
+            returnable.append(dockItem)

         }

@Tatsh
Copy link

Tatsh commented Mar 29, 2019

Perhaps you guys have spacer Dock entries like me?

@remus-b
Copy link

remus-b commented Mar 29, 2019

Yes, I can confirm, I have spacer Dock entries :D @Tatsh

@JtMotoX
Copy link

JtMotoX commented Mar 29, 2019

I do not have spacer Dock entries and I am facing this issue (10.13.6) @Tatsh

@pigigaldi
Copy link
Collaborator

Keep visit http://pock.pigigaldi.com, an update will be available soon that should fix this issue too.

@wtlyu
Copy link

wtlyu commented Mar 29, 2019

yes :D I have lots of spacer Dock entries LOL

@ghost
Copy link

ghost commented Mar 29, 2019

@Tatsh Good call! I removed my spacers and now it runs fine. I will of course grab the fix when it's available, but I don't mind going spacerless for a little while so I can start playing with Pock. :)

@pigigaldi pigigaldi added this to the 0.4.2 milestone Mar 29, 2019
@woolson
Copy link

woolson commented Mar 29, 2019

@pigigaldi still crash on start up.

    MBP: MacBook Pro (15-inch, 2017)
     OS: 10.14.4 (18E226)
Version: 0.4.2

@pigigaldi
Copy link
Collaborator

Thanks for the feedback! Maybe I need more time to investigate these cases.

pigigaldi added a commit that referenced this issue Mar 30, 2019
@pigigaldi
Copy link
Collaborator

#25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

9 participants