Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Feature: Time Format Customization #255

Closed
wants to merge 16 commits into from
Closed

New Feature: Time Format Customization #255

wants to merge 16 commits into from

Conversation

L1cardo
Copy link
Contributor

@L1cardo L1cardo commented Oct 12, 2019


name: add new feature
about: Create a pull request to contribute in making Pock amazing!
title: 'add new feature'
labels: ''
assignees: ''


Describe the Pull request

  1. add time format customization. this will fix time format issue in some regions. For example in China ,we use year month day time instead of year day month time
    截屏2019-10-12下午4 34 19
  2. add simpilified Chinese readme
  3. update some simpilified Chinese localization
  4. nowplaying supports google chrome

Screenshots
Time format:
image
image

An interesting feature:
it supports emoji!
image

Fixes
fix some region time format issue
fix #132

Pull request type
Keep only the option that better matches your pull request.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Tested?
Yes

Test Configuration:

  • Hardware: MacBook Pro (13-inch, 2018, Four Thunderbolt 3 Ports)
  • macOS Version: 10.15
  • Xcode version: 11.1

Checklist
Use this list to keep track of your progress:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@L1cardo L1cardo changed the title add new feature Add New Features: Time Format Customization Oct 13, 2019
@L1cardo L1cardo changed the title Add New Features: Time Format Customization New Feature: Time Format Customization Oct 13, 2019
@L1cardo
Copy link
Contributor Author

L1cardo commented Oct 29, 2019

Time format textfield can live check textchange now, we don't need OK button anymore!
This is what it looks like now!

demo

@L1cardo
Copy link
Contributor Author

L1cardo commented Nov 3, 2019

demo

@pigigaldi
Copy link
Collaborator

Merged and included in 0.6.3
Thanks, @L1cardo 🎉

@pigigaldi pigigaldi closed this Nov 3, 2019
@L1cardo
Copy link
Contributor Author

L1cardo commented Nov 3, 2019

@pigigaldi
Haha you’re welcome!
You may want to change the url of time format help button, I didn’t find a proper website to let time formatting easy and clear for users, so I just added a url of another app.
I don’t know if it is OK to open another app’s website when using Pock.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only show date
2 participants