-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement liquidation for a specific period #20
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Terraform Initialization ⚙️
|
Terraform Initialization ⚙️
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #19
Changes
sequence
AS-IS
既存の清算シナリオは「清算→清算額計算→清算完了」で、全期間での清算、すなわち合計支払額の不均衡を解消することしかできない。
この清算では、各ユーザーの支払い合計額を payAmount で保持しているのでそれを使っている。
CHANGE-TO
AS-ISの清算シナリオに1ステップ追加し、期間を指定できるようにする。「清算→期間選択→清算額計算→清算完了」。
この場合、指定された期間内に起こった支払いのみを清算する。
個々の支払いの履歴が必要となるため、payments collectionを今回追加する。
期間の入力にはわかりやすさのため 日時選択アクション を使用する。postback dataの保存が必要のため新たにstoreにliquidations collectionを用意する。
Limitation
Refactoring
Future Works