Rewrite website with astro #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raahii
force-pushed
the
rewrite-website-with-astro
branch
5 times, most recently
from
afdb3cb
to
1b6f940
Compare
raahii
force-pushed
the
rewrite-website-with-astro
branch
from
1b6f940
to
34740af
Compare
raahii
force-pushed
the
rewrite-website-with-astro
branch
from
e636b37
to
fc6170b
Compare
raahii
force-pushed
the
rewrite-website-with-astro
branch
from
64a7ddb
to
af553cc
Compare
raahii
commented
Jan 29, 2023
Comment on lines
+61
to
+67
| Using !imporant is workaround for astro bug (probably). | ||
| Astro generates htmls that increrectly load styles in other pages. | ||
| e.g. top page (index.html) loads help page css(/_astro/help.9ec21e7e.cs). | ||
|
|
||
| The document says that <style> CSS rules are automatically scoped by default, so it's weired. | ||
| I confirm this until the astro version v2.0.2. | ||
| https://docs.astro.build/en/guides/styling/#scoped-styles |
There was a problem hiding this comment.
引っかかったのはここだけ。Astro 良い感じ。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://haraiai.netlify.app を Astro で書き換える