Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The context on routerAdd function js bindings are wrong #4145

Closed
nhlmg93 opened this issue Jan 13, 2024 · 2 comments
Closed

The context on routerAdd function js bindings are wrong #4145

nhlmg93 opened this issue Jan 13, 2024 · 2 comments

Comments

@nhlmg93
Copy link

nhlmg93 commented Jan 13, 2024

c.response().header().set() api is being generated wrong either by goja or your typescript. the set method only accepts a key and not a value.

pocket_base_bug

Note: the set will run and not error when just the key is passed like in the attached photo. however if you try to pass two it will fail. so i suspect its not the type generator.

@ganigeorgiev
Copy link
Member

Hm, indeed the last argument is missing from the declaration for some reason.

I'll move the issue to the tygoja repo and will investigate it sometime later this weekend.

@ganigeorgiev
Copy link
Member

Should be fixed in v0.20.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants