Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bitbucket OAuth provider #3948

Closed
wants to merge 1 commit into from

Conversation

aabajyan
Copy link
Contributor

Hello, this is my first commit. If there's any issues let me know!

I tested with JS-SDK and I managed to sign in.
I ran make test and it seems to work fine.
I also ran make lint and no new errors was found.

You can create a new OAuth app here https://support.atlassian.com/bitbucket-cloud/docs/use-oauth-on-bitbucket-cloud/

Copy link
Member

@ganigeorgiev ganigeorgiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I left some comments, feel free to check them when you find time.

I'll be able to test and review the integration in more details over the weekend.

tools/auth/bitbucket.go Outdated Show resolved Hide resolved
tools/auth/bitbucket.go Outdated Show resolved Hide resolved
tools/auth/bitbucket.go Show resolved Hide resolved
ganigeorgiev added a commit that referenced this pull request Dec 17, 2023
Co-authored-by: aabajyan <arsen.abajyan@pm.me>
ganigeorgiev added a commit that referenced this pull request Dec 17, 2023
Co-authored-by: aabajyan <arsen.abajyan@pm.me>
@ganigeorgiev
Copy link
Member

I was able to test the integration and everything seems to work fine!

I've squash-merged the PR locally in the develop branch with some minor modifications:

  • added checks for the account_status:active field in case the account is suspended for some reason
  • refactored the primary email function to ignore only the request errors for consistency with the other similar providers and to help with the debugging in case something else has gone wrong

The provider will be part of the next v0.21.0 release (there is no ETA yet).

@aabajyan aabajyan deleted the add-bitbucket branch December 17, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants