Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add settings activity #938

Closed
wants to merge 4 commits into from

Conversation

larsgrefer
Copy link
Contributor

Not ready to merge yet.
I just want to start sharing my ideas about this, get a discussion going and collect ideas.

Things i'd like to add:

  • Icons for Preference-Elements
  • Report a bug-Element

Maybe:

  • View/Fork us on github-Element
  • Open Source Licenses-Element

The first draft:
screenshot_20151015-000721

@larsgrefer
Copy link
Contributor Author

related to #66

@StefMa
Copy link
Contributor

StefMa commented Oct 19, 2015

It would be cool if we can manage the github account.
Like https://github.com/settings/profile to change:

  • Avatar
  • Name
  • URL
  • Company
  • Location
  • Password
  • Username
  • Change/Add E-Mails

etc.

@fadils
Copy link
Member

fadils commented Nov 18, 2015

@larsgrefer how is it going?

@larsgrefer
Copy link
Contributor Author

@fadils waiting for #939 being fixed, because the report a bug feature is pretty useless otherwise

@fadils
Copy link
Member

fadils commented Nov 19, 2015

Are you saying that you're holding the whole setting feature because one part of setting can't be done?

@larsgrefer
Copy link
Contributor Author

  • The "report a bug" feature is implemented and already present in this PR, but it is not working.
  • The icons aren't implemented yet, because I was waiting for a stable version com.android.tools.build:gradle:1.4.x (because of the automatic vector -> png conversion)

If you'd like to merge this, feel free to do so.

@StefMa
Copy link
Contributor

StefMa commented Nov 19, 2015

Gradle build tools plugin 1.5 is available :-)
Am 19.11.2015 10:05 nachm. schrieb "Lars Grefer" notifications@github.com:

  • The "report a bug" feature is implemented and already present in
    this PR, but it is not working.
  • The icons aren't implemented yet, because I was waiting for a stable
    version com.android.tools.build:gradle:1.4.x (because of the automatic
    vector -> png conversion)

If you'd like to merge this, feel free to do so.


Reply to this email directly or view it on GitHub
#938 (comment).

@larsgrefer
Copy link
Contributor Author

@StefMa I have just noticed that too.
1.4x is still beta, but 1.5.0 is released

@larsgrefer
Copy link
Contributor Author

@StefMa I've implemented the icons

@larsgrefer
Copy link
Contributor Author

screenshot_20151121-180223

@StefMa
Copy link
Contributor

StefMa commented Nov 21, 2015

Is this really a settings page or more a about (or something) page? :-)
See not a single setting here...
Am 21.11.2015 6:05 nachm. schrieb "Lars Grefer" notifications@github.com:

[image: screenshot_20151121-180223]
https://cloud.githubusercontent.com/assets/6069961/11319522/3f556c94-907a-11e5-931b-426d2688886a.png


Reply to this email directly or view it on GitHub
#938 (comment).

@larsgrefer
Copy link
Contributor Author

Its a settings activity with only one category. More categories can be added in the future

@fadils
Copy link
Member

fadils commented Nov 23, 2015

Could you please add those setting categories in this PR as well?

@fadils
Copy link
Member

fadils commented Nov 25, 2015

@larsgrefer any chance to add those setting?

@larsgrefer
Copy link
Contributor Author

@fadils At the moment im working on the profile settings mentioned by @StefMa

@fadils
Copy link
Member

fadils commented Nov 25, 2015

Alright..

@lordcodes
Copy link

If you look at the Material Design spec for settings pages:

https://www.google.com/design/spec/patterns/settings.html#settings-grouping-settings

It suggests having settings grouped based on how many settings there are. I wouldn't have icons on the options unless it helps make the settings easier to understand or to find them quicker. I.e. when someone is looking for sound settings a speaker icon can really help.

Therefore, often you only see icons when it is the root page of settings with different groups on it (like in the stock Android settings app). Unless you have a lot of different settings, this top-level group page wouldn't be required.

So in the example above I personally, don't think icons are required for version and build. I would have Report a bug with an icon as the top option (not under a section header). Then, under About I would have the other two. The about section would move down when other settings sections are added, as things that are actually settings will probably be more regularly used by users.

@ZacSweers
Copy link
Contributor

I agree. I'm actually going to close this for now seeing as it never got anywhere. We can revisit in the future if and when more settings use cases arise

@ZacSweers ZacSweers closed this Feb 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants