New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add settings activity #938
Conversation
related to #66 |
It would be cool if we can manage the github account.
etc. |
@larsgrefer how is it going? |
Are you saying that you're holding the whole setting feature because one part of setting can't be done? |
2dca6cd
to
a403d02
Compare
If you'd like to merge this, feel free to do so. |
Gradle build tools plugin 1.5 is available :-)
|
@StefMa I have just noticed that too. |
@StefMa I've implemented the icons |
Is this really a settings page or more a about (or something) page? :-)
|
Its a settings activity with only one category. More categories can be added in the future |
Could you please add those setting categories in this PR as well? |
@larsgrefer any chance to add those setting? |
Alright.. |
If you look at the Material Design spec for settings pages: https://www.google.com/design/spec/patterns/settings.html#settings-grouping-settings It suggests having settings grouped based on how many settings there are. I wouldn't have icons on the options unless it helps make the settings easier to understand or to find them quicker. I.e. when someone is looking for sound settings a speaker icon can really help. Therefore, often you only see icons when it is the root page of settings with different groups on it (like in the stock Android settings app). Unless you have a lot of different settings, this top-level group page wouldn't be required. So in the example above I personally, don't think icons are required for version and build. I would have Report a bug with an icon as the top option (not under a section header). Then, under About I would have the other two. The about section would move down when other settings sections are added, as things that are actually settings will probably be more regularly used by users. |
I agree. I'm actually going to close this for now seeing as it never got anywhere. We can revisit in the future if and when more settings use cases arise |
Not ready to merge yet.
I just want to start sharing my ideas about this, get a discussion going and collect ideas.
Things i'd like to add:
Maybe:
The first draft: