Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: show video caption in tab #1037

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: show video caption in tab #1037

wants to merge 2 commits into from

Conversation

j-bitmaker
Copy link
Contributor

@j-bitmaker j-bitmaker commented May 9, 2023 •
edited

Standards checklist:

  • The PR title is descriptive.
  • The PR doesn't replicate another PR which is already open.
  • The PR has self-explained commits history.
  • The code is mine or it's from somewhere with an Apache-2.0 compatible license.
  • The code is efficient, to the best of my ability, and does not waste computer resources.
  • The code is stable and I have tested it myself, to the best of my abilities.
  • If the code introduces new classes, methods, I provide a valid use case for all of them.

Changes:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxgithubprofile maxgithubprofile Awaiting requested review from maxgithubprofile

@shpingalet007 shpingalet007 Awaiting requested review from shpingalet007

At least 1 approving review is required to merge this pull request.

Assignees

@j-bitmaker j-bitmaker

Labels
contribution type: ✨ feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@j-bitmaker @maxgithubprofile @shpingalet007