Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruff - double quotes preferred #157

Merged
merged 1 commit into from
May 16, 2024

Conversation

chrisaddy
Copy link
Collaborator

@chrisaddy chrisaddy commented May 14, 2024

Changes

convert all single quotes to double quotes to appease the Ruff Lord.

There are no other changes besides this linting.

Copy link
Collaborator Author

chrisaddy commented May 14, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @chrisaddy and the rest of your teammates on Graphite Graphite

Copy link
Collaborator

@forstmeier forstmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is adding back in stuff that's been deprecated and it looks like Git conflict indicators (e.g. <<<<<<< HEAD) have been included.

@chrisaddy chrisaddy mentioned this pull request May 15, 2024
Copy link
Collaborator Author

should be fixed

@chrisaddy chrisaddy force-pushed the 05-14-ruff_-_double_quotes_preferred branch from d983e47 to 3f359c3 Compare May 15, 2024 02:23
@chrisaddy chrisaddy changed the base branch from 05-14-ruff_linting_in_ci to master May 15, 2024 02:23
@chrisaddy chrisaddy mentioned this pull request May 15, 2024
@forstmeier
Copy link
Collaborator

forstmeier commented May 15, 2024

Huh, that's weird, @chrisaddy I still see the Git merge lines and some deprecated resources (e.g. postperformance Lambda resources). I see that there are conflicts with the base branch per GitHub.

@chrisaddy chrisaddy force-pushed the 05-14-ruff_-_double_quotes_preferred branch 4 times, most recently from 5660b0f to 1a0cb49 Compare May 15, 2024 17:41
@chrisaddy chrisaddy requested a review from forstmeier May 16, 2024 03:06
@chrisaddy chrisaddy force-pushed the 05-14-ruff_-_double_quotes_preferred branch 2 times, most recently from ce9da06 to ea5a850 Compare May 16, 2024 16:46
@chrisaddy chrisaddy force-pushed the 05-14-ruff_-_double_quotes_preferred branch from ea5a850 to bf14f17 Compare May 16, 2024 16:49
@chrisaddy chrisaddy merged commit dfc56c3 into master May 16, 2024
4 of 5 checks passed
Copy link
Collaborator Author

Merge activity

@forstmeier forstmeier deleted the 05-14-ruff_-_double_quotes_preferred branch May 17, 2024 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants