Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Elliptical arc command #114

Merged
merged 1 commit into from Mar 21, 2018
Merged

Implement Elliptical arc command #114

merged 1 commit into from Mar 21, 2018

Conversation

yarry
Copy link

@yarry yarry commented Mar 9, 2018

No description provided.

@yarry yarry mentioned this pull request Mar 9, 2018
Closed
@arielelkin
Copy link
Collaborator

Looks good to me!

@fjolnir are you ok to merge ?

@adrienthiery
Copy link

Super cool!
I spend a bunch of time on this myself last week but didn't end up with a working solution 😅

fjolnir
fjolnir approved these changes Mar 21, 2018
View reviewed changes
Copy link
Member

@fjolnir fjolnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable names are a bit hard to follow, but I guess that can't be helped in this case :)

@fjolnir fjolnir merged commit e00e570 into pocketsvg:master Mar 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjolnir fjolnir fjolnir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yarry @arielelkin @adrienthiery @fjolnir