Treat SVGColors.plist as a resource instead of source code. #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the "Unexpected duplicate tasks" error when building with Xcode 11.
|
Hey @arielelkin ! can you merge this pr? |
|
Looks fine. But before I merge this, we need to finish off xcode 11 migration: A test is failing when CI is run on that branch, so any ideas on how to fix it are welcome. |
|
merged via #169 |
|
thanks @clindsay ! |
|
No problem @arielelkin! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the "Unexpected duplicate tasks" error when building with Xcode 11. (#163)
The SVGColors.plist file was being included as a source file, rather than a resource. Xcode 11 seems to find this more problematic than previous versions.