Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pkg-name in find_package_handle_standard_args #3067

Closed
wants to merge 1 commit into from

Conversation

Krzmbrzl
Copy link

@Krzmbrzl Krzmbrzl commented Aug 8, 2020

For the MySQL package find_package_handle_standard_args got passed "MYSQL" as the package name, which differs from
the actual package name. Due to this cmake (3.18) emitted a warning.
This commit fixes this issue by also passing "MySQL" to find_package_handle_standard_args.

Fixes #3066

For the MySQL package find_package_handle_standard_args got passed "MYSQL" as the package name, which differs from
the actual package name. Due to this cmake (3.18) emitted a warning.
This commit fixes this issue by also passing "MySQL" to find_package_handle_standard_args.

Fixes pocoproject#3066
@obiltschnig obiltschnig self-assigned this Aug 10, 2020
@obiltschnig obiltschnig added this to the Release 1.10.2 milestone Aug 10, 2020
@Bjoe
Copy link
Contributor

Bjoe commented Apr 21, 2021

But still the question is, should we also "camel-case" the other Variable Names?
See https://cmake.org/cmake/help/latest/manual/cmake-developer.7.html#standard-variable-names

But this will break others build system. Maybe rename FindMySQL.cmake to FindMYSQL.cmake and add a FindMySQL.cmake and give a warning that this is deprecated and they should use FindMYSQL.cmake ?

@Krzmbrzl
Copy link
Author

But still the question is, should we also "camel-case" the other Variable Names?
See cmake.org/cmake/help/latest/manual/cmake-developer.7.html#standard-variable-names

Yeah that'd probably have to be done as well 🤔

But this will break others build system. Maybe rename FindMySQL.cmake to FindMYSQL.cmake and add a FindMySQL.cmake and give a warning that this is deprecated and they should use FindMYSQL.cmake ?

By renaming the FindMYSQL, it should not interfere with any project using poco, should it? In that case I don't even see the need for providing a FindMySQL at all 👀

@obiltschnig
Copy link
Member

Leaving it at FindMySQL.cmake for now, as we have the same issue with PostgreSQL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CMake warning about MYSQL casing
3 participants