PostgreSQL get sqlcode

[omerbrandis]

hello all,

I've started using poco::data , v1.11.0. ( I seems like a wonderful lib, thanks for creating it ).

I seem to be unable to find a statements sqlcode.

at least when I use Poco::Data::PostgreSQL::PostgreSQLException, with postgresql v15.3
and have a failing insert statement with the following msg "the display text is "ERROR: null value in column "...l" of relation "..." violates not-null constraint" ,
the value returned by exception.code() is 0.
while I expected to see something like 23502.

so either this is a bug,
Or I am looking in the wrong place.

Please advise,
Omer.

[omerbrandis]

as far as i can tell, its simply not implemented.

Data/Postgresql/StatementExecutor.cpp :

// setup to clear the result from PQprepare
		PQResultClear resultClearer(ptrPGResult);

		if	(!ptrPGResult || PQresultStatus(ptrPGResult) != PGRES_COMMAND_OK)
		{
			throw StatementException(std::string("postgresql_stmt_prepare error: ") + PQresultErrorMessage (ptrPGResult) + " " + aSQLStatement);
		}

I did find an attempt to do so in

if (!ptrPGResult || (PQresultStatus(ptrPGResult) != PGRES_COMMAND_OK &&
		PQresultStatus(ptrPGResult) != PGRES_TUPLES_OK))
	{
		PQResultClear resultClearer(ptrPGResult);

		const char* pSeverity	= PQresultErrorField(ptrPGResult, PG_DIAG_SEVERITY);
		const char* pSQLState	= PQresultErrorField(ptrPGResult, PG_DIAG_SQLSTATE);
		const char* pDetail		= PQresultErrorField(ptrPGResult, PG_DIAG_MESSAGE_DETAIL);
		const char* pHint		= PQresultErrorField(ptrPGResult, PG_DIAG_MESSAGE_HINT);
		const char* pConstraint	= PQresultErrorField(ptrPGResult, PG_DIAG_CONSTRAINT_NAME);

		throw StatementException(std::string("postgresql_stmt_execute error: ")
			+ PQresultErrorMessage (ptrPGResult)
			+ " Severity: " + (pSeverity   ? pSeverity   : "N/A")
			+ " State: " + (pSQLState   ? pSQLState   : "N/A")
			+ " Detail: " + (pDetail ? pDetail : "N/A")
			+ " Hint: " + (pHint   ? pHint   : "N/A")
			+ " Constraint: " + (pConstraint ? pConstraint : "N/A"));
	}

but this seems to be incorrect implementation, the pSQLState is returned as part of a string, which defeats the purpose of SQLState ( to have a numeric return value and allow the user to avoid string parsing to determine how to proceed).

[omerbrandis]

added pull request #4099